1588131 - with searchbar in overflow menu, switching from it to addressbar and typing shows suggestions, but arrow down collapses - searchbar remains open them

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 71.0a1 20191011093010 on Windows 8.1

With the searchbar in the overflow menu, switching from it to the addressbar and typing shows suggestions, but pressing arrow down collapses them instead of selecting the first suggestion.

Steps to reproduce:

1. Right-click toolbar > Customize.
2. Position the searchbar in the overflow menu and finish the customization.
3. Open the searchbar (e.g. Ctrl+K).
4. Switch to the locationbar (Ctrl+L) - searchbar remains open.
5. Type something (actual & expected: history etc. shown).
6. Press arrow down to select the first suggested item.

Actual result:
First item not selected but suggested items disappear.

Expected result:
First item selected.
Searchbar hidden after step 4.

Comment 1

[Marco Bonardo [:mak]]

For me it's enough for the overflow panel to be opened to cause the bug.
This is not a common use-case, so I don't think it's critical.
It would be nice to have a regression range, that can be obtained easily using mozregression.

Comment 2

[Timea Cernea [:tbabos][inactive]]

Hey Marco,

I got the following regression-window:
Last good revision: ec1f3a922d56e0a9393415872ee1d30c2f895fd7
First bad revision: 9f0f38c38ccce7c9656c77205b16dfb35208df2d

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ec1f3a922d56e0a9393415872ee1d30c2f895fd7&tochange=9f0f38c38ccce7c9656c77205b16dfb35208df2d

Unfortunately, I couldn't go further, the firefox window suddenly closes if I drag any icon from the customize panel.
However, I believe Bug 1477673 could be a possible regressor for this issue. Please take a look at it when you have the chance.
Hope this helps!

Comment 3

[Marco Bonardo [:mak]]

It's a good guess, thanks for looking into the regwindow.

Comment 4

[Drew Willcoxon :adw]

Still happens on the latest Nightly.

Comment 6

[Chris Bellini (:cbellini)]

Resolved as part of the resolution of 1626741.