Closed Bug 1588292 Opened 5 years ago Closed 5 years ago

Add new sponsorship links to home page and development page

Categories

(SeaMonkey :: Website, enhancement)

Production
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.68

People

(Reporter: rpmdisguise-nave, Assigned: rpmdisguise-nave)

References

()

Details

Attachments

(2 files, 3 obsolete files)

We've got a new sponsor (actually, there are up to five marks involved) and it has been decided by SeaMonkey Council to add a note with the respective five links. The patch also removes completely the provision for a logo in the main page in sidebar.tmpl.

Patch removing commented out remnants in sidebar and adding links in both main page and development page. I'm happy to accept suggestions/corrections on HTML source formatting. The links are set to open in new page/tab.

Attachment #9100660 - Flags: review?(iann_bugzilla)
Attachment #9100660 - Flags: review?(frgrahl)
Comment on attachment 9100660 [details] [diff] [review]
New sponsorship links for SeaMonkey website

NIT: Bug Missing at first word in comment eg. Bug 1588292 - New sponsor for SeaMonkey

+  <a href="https://www.dotcom-monitor.com/"   target="_blank">dotcom-monitor</a>,
+  <a href="https://www.loadview-testing.com/" target="_blank">loadview</a>,
+  <a href="https://webhostingbuddy.com/"      target="_blank">WebHostingBuddy.com</a>,
+  <a href="https://webhostingprof.com/"       target="_blank">Web Hosting Professor</a> and
+  <a href="https://www.drivencoffee.com/"     target="_blank">Driven Coffe Roasters</a>.

There should be enough space to extend the actual website names. Maybe from the landing pages with some redactions?

Website Monitoring & Performance Testing - Dotcom-Monitor
Load Testing & Website Performance Tools - LoadView
Honest Web Hosting Reviews & Tech Tips - WebHostingBuddy.com
Web Hosting Professor - Best Web Hosting Reviews on the Net
Driven Coffee Roasters  - Buy the Best Coffee Beans Online

NIT: In any case coffee with two e. When it is up maybe ask the sponsor and do a follow-up.

f+ with NITs corrected and let IanN decide about the final r+
Attachment #9100660 - Flags: review?(frgrahl) → feedback+

Thanks, fixed the comment and the missing "e".

I'd like to hear other opinions about the extended website names. If we write them in a paragraph, it's going to be a bit long and mixed, and if we use an unordered list, the project news will be moved outside the viewport. Also, regardless of how it is displayed in each website, I'd write all the same way, with the website name, made a link, first, and the description following it, either separated by an hyphen or enclosed in parenthesis:

Dotcom-Monitor - Website Monitoring & Performance Testing
Dotcom-Monitor (Website Monitoring & Performance Testing)

Comment on attachment 9100660 [details] [diff] [review]
New sponsorship links for SeaMonkey website

Thanks for the work so far.
Maybe on the Dev page have a new section Sponsorship, linked from the top of the page that as the more complete information mentioned by frg. It is just whether that new section belongs in the Dev page, probably okay for the short term.
On the main page, stick with the list you have with a link through to the new Sponsorship section.

f+ for the moment as would like to review the updated patch
Attachment #9100660 - Flags: review?(iann_bugzilla) → feedback+

Fixed previous issues, and added the extended info for each sponsor/link in Dev page on a new section.

I miss an email for contacting SeaMonkey e.V. :'-( But that's another topic.

Attachment #9100660 - Attachment is obsolete: true
Attachment #9100755 - Flags: review?(iann_bugzilla)
Attachment #9100755 - Flags: review?(frgrahl)
Comment on attachment 9100755 [details] [diff] [review]
New sponsorship links for SeaMonkey website

>+++ b/src/index.en.html

>+<p>SeaMonkey is proudly sponsored by
Maybe have "sponsored" as a link through to the sponsored section or would that be too confusing?

r=me with that answered/addressed.
Attachment #9100755 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 9100755 [details] [diff] [review]
New sponsorship links for SeaMonkey website

Looks good.
Attachment #9100755 - Flags: review?(frgrahl) → review+
Status: NEW → ASSIGNED

New patch adding the suggested link by Ian

Attachment #9100755 - Attachment is obsolete: true
Attachment #9101393 - Flags: review?(iann_bugzilla)
Attachment #9101393 - Flags: review?(frgrahl)

(In reply to Ian Neal from comment #6)

Comment on attachment 9100755 [details] [diff] [review]
New sponsorship links for SeaMonkey website

+++ b/src/index.en.html

+<p>SeaMonkey is proudly sponsored by
Maybe have "sponsored" as a link through to the sponsored section or would
that be too confusing?

r=me with that answered/addressed.

Makes sense to me, thank you. Added in a new version of the patch. Frank, sorry for the bugspam. :-)

Comment on attachment 9101393 [details] [diff] [review]
New sponsorship links for SeaMonkey website

>+++ b/src/index.en.html
>+<p>SeaMonkey is <a href="dev/index.en.html#sponsoring">proudly</a> sponsored by
I'd have the link text include the "sponsored".

r=me with that fixed.
Attachment #9101393 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 9101393 [details] [diff] [review]
New sponsorship links for SeaMonkey website

r+ and a push with the NIT fixed
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/f6d68416fdc393cd38bc9996ccfe1333dce0e8f7
Attachment #9101393 - Flags: review?(frgrahl) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.68
Version: unspecified → Production
Attached patch 1588292-part2.patch (obsolete) — Splinter Review

I think some announcement might be in order.

Attachment #9104500 - Flags: review?(iann_bugzilla)

typo readers corrected. r+ over irc.

Attachment #9104500 - Attachment is obsolete: true
Attachment #9104500 - Flags: review?(iann_bugzilla)
Attachment #9104501 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: