1588315 - about:protections: Firefox Monitor link mishandles Alias E-mails

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[CaptDöner]

Attachment: broken mail.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Requirement: Have FF account with an alias logged in to Firefox Sync (eg [e-mail])
On about:protections there is a link to Sign-Up for Firefox Monitor.
I clicked it to sign up.

Version 70.0b14
Build-ID 20191010142853

Actual results:

I got a Firefox Auth login page with the e-mail that misses the plus sign. (eg. foo [e-mail]) and a warning that I need to enter a vaild mail.

Expected results:

I see my actual e-mail address on the Firefox Auth page.

Comment 1

[CaptDöner]

Attachment: edited link.PNG

Screenshot with the button and a edited mail.

Comment 2

[Francesco Lodolo [:flod]]

I think the bug is in about:protections, not Monitor.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Erica, can you take a look? We are planning an RC2 build on Wednesday so could still fix this for skyline/70.

Comment 4

[Erica Wright [:ewright]]

Attachment: Bug 1588315 - Firefox Monitor link encodes emails to handle special characters.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25924fb78062
Firefox Monitor link encodes emails to handle special characters. r=MattN

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Ciprian or Hani, can you verify this in nightly for tomorrow? Thanks!

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

CaptDöner, can you verify this works in nightly (once nightly updates with this fix, probably a bit later today)?

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/25924fb78062

Comment 9

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 71.0a1 (2019-10-16) on Windows 10 x64, macOS 10.14 and Ubuntu Ubuntu 18.04 x64.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

please request uplift to m-r asap. Thanks!

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9101297 [details]
Bug 1588315 - Firefox Monitor link encodes emails to handle special characters.

We need this on m-r this morning for the RC2 build.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/990d9f90f0f5

Comment 13

[CaptDöner]

Wow, that was fast. I can also confirm that the bug is fixed in the latest nightly version.

Comment 14

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 70.0 RC2 on Windows 10 x64, macOS 10.14 and Ubuntu Ubuntu 18.04 x64.