1588343 - [wpt-sync] Sync PR 19657 - [html] Clean state between dialog positioning tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19657 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19657
Details from upstream follow.

Darryl Pogue <[e-mail]> wrote:

[html] Clean state between dialog positioning tests

Calling reset() at the end of every test to close the modal dialog will only be invoked if the test passes. If an expectation fails, the call to reset() will never run and the dialog will remain modally open on the page. This causes all further tests to fail because calling showModal() on the dialog while it is open is an error.

Instead, set up reset() to be called as a cleanup after every test regardless of whether the test passes or fails.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9375439b7c3f2d5b3ac78fe52633b9fc183bae52

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

## GitHub CI Results
wpt.fyi [PR Results](https://wpt.fyi/results/?sha=e5703f32bba57534b5721982bec8602ea6eff742&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=e5703f32bba57534b5721982bec8602ea6eff742&label=pr_base)

Ran 2 tests and 23 subtests

### Firefox
  OK    : 1
  FAIL  : 16
  ERROR : 1
  NOTRUN: 7

### Chrome
  OK  : 2
  PASS: 22
  FAIL: 1

### Safari
  OK    : 1
  FAIL  : 16
  ERROR : 1
  NOTRUN: 7

### Existing tests that now have a worse result

/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html: Firefox: OK->ERROR, Chrome: OK->OK, Safari: OK->ERROR
   opening dialog with multiple focusable children: Firefox: FAIL->NOTRUN, Chrome: PASS->PASS, Safari: FAIL->NOTRUN
   opening dialog with multiple focusable children, one having the autofocus attribute: Firefox: FAIL->NOTRUN, Chrome: PASS->PASS, Safari: FAIL->NOTRUN
   showModal() on a <dialog> not in a Document throws an InvalidStateError exception: Firefox: FAIL->NOTRUN, Chrome: PASS->PASS, Safari: FAIL->NOTRUN
   opening dialog without focusable children: Firefox: FAIL->NOTRUN, Chrome: FAIL->FAIL, Safari: FAIL->NOTRUN
   when opening multiple dialogs, only the newest one is non-inert: Firefox: FAIL->NOTRUN, Chrome: PASS->PASS, Safari: FAIL->NOTRUN
   showModal() on a <dialog> after initial showModal() and removing the open attribute: Firefox: FAIL->NOTRUN, Chrome: PASS->PASS, Safari: FAIL->NOTRUN
   when opening multiple dialogs, the most recently opened is rendered on top: Firefox: FAIL->NOTRUN, Chrome: PASS->PASS, Safari: FAIL->NOTRUN

## Gecko CI Results

Ran 2 tests and 23 subtests
  OK     : 2
  PASS   : 5
  FAIL   : 18

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4b0c19ff248
[wpt PR 19657] - [html] Clean state between dialog positioning tests, a=testonly

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b4b0c19ff248