1588358 - Clean up SeaMonkey migration code

Status: RESOLVED FIXED

(SeaMonkey :: Startup & Profiles, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

Currently the only migration which works is migration from Thunderbird. But even there it tries to migrate some settings and prefs which should not be taken or are not available/make no sense (history, bookmarks). The migration code is also mot separated and breaks frequently with upstream changes. So try to make it a little more aligned with TB and Fx for future enhancements.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1588358-suitemigration.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: no visible impact.
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: None

This could be cleaned up further but should probably be done in a follow-up bug. The sturcuture matches the one form TB afterwards but might be a little overkill for the few files. Unsure.

Comment 2

[Ian Neal]

Comment on attachment 9100734 [details] [diff] [review]
1588358-suitemigration.patch

[Triage Comment]
r/a=me I think this is probably the best starting point but I presume there will be follow-up bugs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2abc5e2495fc
Untangle suite profile and migration source and clean it up. r=IanN

Comment 4

[Frank-Rainer Grahl (:frg)]

Patches for esr60 and comm-central needed some rebasing.

https://hg.mozilla.org/releases/comm-esr60/rev/ad9f64a2ef8d1788dd77c32053c3ab940d08e049

Comment 5

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/7d7d4a4dddc55f1e22e642ed2acb8ae2ce8dce71