Closed Bug 1588444 Opened 2 months ago Closed 2 months ago

Show formatted message content over collapsed raw

Categories

(DevTools :: Netmonitor, enhancement, P2)

enhancement

Tracking

(firefox71 fixed, firefox72 fixed)

RESOLVED FIXED
Firefox 72
Tracking Status
firefox71 --- fixed
firefox72 --- fixed

People

(Reporter: Harald, Assigned: mustafa.abdelmogoud)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

When inspecting messages that have nice formatted content, I want to see the formatted version first (and only later expand the raw version if I want to stare at unformatted output) so that I can see the best possible version.

High priority as raw format pushed the formatted tab down.

(In reply to :Harald Kirschner :digitarald from comment #0)

Created attachment 9100807 [details]

Note that the screenshot shows an issue (empty JSON tab) that is covered in bug 1587750

Honza

Summary: Show formatted message content over raw and collapse raw → Show formatted message content over collapsed raw

Here are some instructions for anyone interested in fixing this issue:

  1. The piece of code that generates the preview sections (JSON, raw) is here:
    https://searchfox.org/mozilla-central/rev/6866d3a650c826f1cabd123663e84b95ee743701/devtools/client/netmonitor/src/components/websockets/FramePayload.js#154-186

  2. There are also flags indicating whether a section should be opened/closed
    https://searchfox.org/mozilla-central/rev/6866d3a650c826f1cabd123663e84b95ee743701/devtools/client/netmonitor/src/components/websockets/FramePayload.js#165,184

The suggested logic should be implemented along this code base.

Honza

Keywords: good-first-bug

Could I work on it?

Yes, assigned to you, thanks for the help!
Honza

Assignee: nobody → mustafa.abdelmogoud
Status: NEW → ASSIGNED
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a55c4296ac4
Show formatted data over collapsed raw data. r=Honza
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Comment on attachment 9103915 [details]
Bug 1588444 - Show formatted data over collapsed raw data. r=Honza

Beta/Release Uplift Approval Request

  • User impact if declined: WebSocket panel feels a little less polished. This specific issue already came as feedback in our forum.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small code change on a lesser-used panel.
  • String changes made/needed:
Attachment #9103915 - Flags: approval-mozilla-beta?

Comment on attachment 9103915 [details]
Bug 1588444 - Show formatted data over collapsed raw data. r=Honza

Low risk polish in a devtools panel, uplift approved for 71 beta 8, thanks.

Attachment #9103915 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.