1588444 - Show formatted message content over collapsed raw

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P2)

Description

[:Harald Kirschner :digitarald]

Attachment: Raw pushing the formatted section out of view

When inspecting messages that have nice formatted content, I want to see the formatted version first (and only later expand the raw version if I want to stare at unformatted output) so that I can see the best possible version.

High priority as raw format pushed the formatted tab down.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to :Harald Kirschner :digitarald from comment #0)

Created attachment 9100807 [details]

Note that the screenshot shows an issue (empty JSON tab) that is covered in bug 1587750

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Here are some instructions for anyone interested in fixing this issue:

1. The piece of code that generates the preview sections (JSON, raw) is here:
   https://searchfox.org/mozilla-central/rev/6866d3a650c826f1cabd123663e84b95ee743701/devtools/client/netmonitor/src/components/websockets/FramePayload.js#154-186

2. There are also flags indicating whether a section should be opened/closed
   https://searchfox.org/mozilla-central/rev/6866d3a650c826f1cabd123663e84b95ee743701/devtools/client/netmonitor/src/components/websockets/FramePayload.js#165,184

The suggested logic should be implemented along this code base.

Honza

Comment 3

[Mustafa]

Could I work on it?

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yes, assigned to you, thanks for the help!
Honza

Comment 5

[Mustafa]

Attachment: Bug 1588444 - Show formatted data over collapsed raw data. r=Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a55c4296ac4
Show formatted data over collapsed raw data. r=Honza

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0a55c4296ac4

Comment 8

[:Harald Kirschner :digitarald]

Comment on attachment 9103915 [details]
Bug 1588444 - Show formatted data over collapsed raw data. r=Honza

Beta/Release Uplift Approval Request

• User impact if declined: WebSocket panel feels a little less polished. This specific issue already came as feedback in our forum.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small code change on a lesser-used panel.
• String changes made/needed:

Comment 9

[Pascal Chevrel:pascalc (PTO until August 12)]

Comment on attachment 9103915 [details]
Bug 1588444 - Show formatted data over collapsed raw data. r=Honza

Low risk polish in a devtools panel, uplift approved for 71 beta 8, thanks.

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4b70ece3af6c