1588449 - [Automated review] Node tests not being taken into account for code coverage

Status: NEW

(Testing :: Code Coverage, defect, P3)

Description

[Belén [:ladybenko]]

Phabricator URL: https://phabricator.services.mozilla.com/D48870#1482416

Hi, I got this automatic code coverage review in Phabricator about some files not being tested, but they are with node/Jest tests (see https://searchfox.org/mozilla-central/search?q=&path=devtools%2Fclient%2Fapplication%2Ftest%2Fcomponents%2F**%2F*.test.js )

Could Node tests be taken into account for code coverage? Thanks

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Marco, do you know if it would be hard to do ?

Comment 2

[Marco Castelluccio [:marco]]

I don't have much info on the infra of these kind of tests. Are they yet another kind of test? Are they using Node with v8 and so no SpiderMonkey?
If they are run via SpiderMonkey, adding support should be relatively easy.
If they are not, it would be a bit more involved.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:ekyle, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Kyle Lahnakoski [:ekyle]]

I will assume supporting coverage on Node tests is not a priority

Comment 5

[nidhi oberoi]

information about this tests' infrastructure. Are these tests of yet another kind? Is Node v8 being used, meaning SpiderMonkey is not present?
It should be quite simple to add support if they are operated through SpiderMonkey.
It would be a little more involved if they weren't.

https://escortskavya.com/call-girls-in-bangalore/
https://escortskavya.com/ub-city-escorts/
https://escortskavya.com/rt-nagar-escorts/
https://escortskavya.com/residency-road-escorts/
https://escortskavya.com/rajaji-nagar-escorts/
https://escortskavya.com/pete-area-escorts/
https://escortskavya.com/nandi-hills-escorts/
https://escortskavya.com/mg-road-escorts/
https://escortskavya.com/marathahalli-escorts/
https://escortskavya.com/malleswaram-escorts/
https://escortskavya.com/majestic-escorts/
https://escortskavya.com/mahadevapura-escorts/
https://escortskavya.com/koramangala-escorts/
https://escortskavya.com/jayanagar-escorts/
https://escortskavya.com/jp-nagar-escorts/
https://escortskavya.com/itpl-escorts/
https://escortskavya.com/indira-nagar-escorts/
https://escortskavya.com/hsr-layout-escorts/
https://escortskavya.com/hoodi-escorts/
https://escortskavya.com/electronic-city-escorts/
https://escortskavya.com/ejipura-escorts/
https://escortskavya.com/domlur-escorts/
https://escortskavya.com/cantonment-escorts/
https://escortskavya.com/btm-layout-escorts/
https://escortskavya.com/brigade-road-escorts/
https://escortskavya.com/bellandur-escorts/
https://escortskavya.com/banaswadi-escorts/
https://escortskavya.com/banashankari-escorts/
https://escortskavya.com/anjanapura-escorts/
https://escortskavya.com/100-feet-road-escorts/
https://escortskavya.com/vidyaranyapura-escorts/

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:marco, since the bug has recent activity, could you have a look please?

For more information, please visit BugBot documentation.