1588467 - WebRender's IntProfileCounters can be hard to read when they change quickly

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

Having averages and maximums over half a second would be more useful.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1588467 - Implement AverageIntProfileCounter. r=gw

AverageIntProfileCounter records the average and maximum of sampled interger values over time slices of half a second. Using it instead of IntProfileCounter in some places will make it easier to notice single-frame spikes.

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1588467 - Implement AverageTimeProfileCounter on top of AverageIntProfileCounter. r=gw

Depends on D49127

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1588467 - Use AverageIntProfileCounter instead of IntProfileCounter in some places. r=gw

Depends on D49128

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 1588467 - Remove unused methods. r=gw

Depends on D49129

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81dc1b8ffd78
Implement AverageIntProfileCounter. r=gw
https://hg.mozilla.org/integration/autoland/rev/5e2b15423100
Implement AverageTimeProfileCounter on top of AverageIntProfileCounter. r=gw
https://hg.mozilla.org/integration/autoland/rev/a62a4d82e376
Use AverageIntProfileCounter instead of IntProfileCounter in some places. r=gw
https://hg.mozilla.org/integration/autoland/rev/0efa1fb81c51
Remove unused methods. r=gw

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/81dc1b8ffd78
https://hg.mozilla.org/mozilla-central/rev/5e2b15423100
https://hg.mozilla.org/mozilla-central/rev/a62a4d82e376
https://hg.mozilla.org/mozilla-central/rev/0efa1fb81c51