1588515 - TypeError: document.getElementById(...) is null in permanent private browsing mode

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[Mark Smith [:mcs]]

Attachment: tor31955.patch

There is some code inside nonBrowserWindowStartup() that assumes it is operating inside the hidden window. This causes JS errors when permanent private browsing mode is enabled on macOS; for example, when windows such as Page Info are opened. STR:

1. Enable permanent private browsing mode via "Never remember history" in about:preferences or by toggling browser.privatebrowsing.autostart to true.
2. Restart Firefox.
3. Load any page, e.g., https://www.mozilla.org/en-US/
4. Press Cmd+I

Check the Browser Console for a message like the following:

TypeError: document.getElementById(...) is null nonbrowser-mac.js:107:14
  nonBrowserWindowStartup chrome://browser/content/nonbrowser-mac.js:107

We patched this in Tor Browser; see https://trac.torproject.org/projects/tor/ticket/31955
I will attach the patch.

Comment 1

[Marco Bonardo [:mak]]

Could you please convert the patch to a phabricator review request?

Comment 2

[Marco Bonardo [:mak]]

I'll take it.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1588515 - TypeError: document.getElementById(...) is null in permanent private browsing mode on Mac. r=gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f775758e2976
TypeError: document.getElementById(...) is null in permanent private browsing mode on Mac. r=Gijs

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f775758e2976