Closed Bug 1588551 Opened Last month Closed Last month

Vector::erase documentation comment has off-by-one error

Categories

(Core :: MFBT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

The comment says that elements from |aEnd + 1| are copied over the erased elements, but it's actually elements starting at |aEnd| that are copied.

https://searchfox.org/mozilla-central/source/mfbt/Vector.h#799

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/916eaf6f094e
Fix Vector::erase documentation comment r=jwalden
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Assignee: nobody → jcoppeard
You need to log in before you can comment on or make changes to this bug.