1588614 - GetBaseDomainInternal shows up badly when opening and closing the menu in CNN, at least when tracking protection is enabled

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

profile
https://perfht.ml/32ee65K

STR,
load https://www.cnn.com/
click on the 'hamburger' menu on top-right-ish of the page

Because of AntiTrackingCommon being on stack, this smells like possible
issue in that code.

Comment 1

[(no longer active)]

The profile in comment 0 is invalid. Does this profile match what you were seeing? https://perfht.ml/2oLms6j

If yes, then this is all from Document::EffectiveStoragePrincipal(). Perhaps we should cache the effective storage principal instead of computing it every time that function is called?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

How is the profile invalid? Your profile looks very similar to mine.
And yes, I was thinking caching too.

Comment 3

[(no longer active)]

(In reply to Olli Pettay [:smaug] from comment #2)

How is the profile invalid? Your profile looks very similar to mine.

Huh... When I tried to load it the other day I got some kind of "profile cannot be found" error (don't remember the exact message any more, sorry). But the link works now. Must have been a transient issue.

And yes, I was thinking caching too.

Sounds good, taking.

Comment 4

[(no longer active)]

Attachment: Bug 1588614 - Cache the document's effective storage principal to avoid running excessive anti-tracking checks;

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55743f55095c
Cache the document's effective storage principal to avoid running excessive anti-tracking checks; r=baku

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/55743f55095c

Comment 7

[(no longer active)]

Profile after the change for comparison: https://perfht.ml/2o6wVsV