Closed Bug 1588614 Opened 5 years ago Closed 5 years ago

GetBaseDomainInternal shows up badly when opening and closing the menu in CNN, at least when tracking protection is enabled

Categories

(Core :: Privacy: Anti-Tracking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: smaug, Assigned: ehsan.akhgari, NeedInfo)

Details

Attachments

(1 file)

profile
https://perfht.ml/32ee65K

STR,
load https://www.cnn.com/
click on the 'hamburger' menu on top-right-ish of the page

Because of AntiTrackingCommon being on stack, this smells like possible
issue in that code.

Flags: needinfo?(ehsan)
Flags: needinfo?(amarchesini)

The profile in comment 0 is invalid. Does this profile match what you were seeing? https://perfht.ml/2oLms6j

If yes, then this is all from Document::EffectiveStoragePrincipal(). Perhaps we should cache the effective storage principal instead of computing it every time that function is called?

Flags: needinfo?(ehsan)
Flags: needinfo?(bugs)

How is the profile invalid? Your profile looks very similar to mine.
And yes, I was thinking caching too.

Flags: needinfo?(bugs)

(In reply to Olli Pettay [:smaug] from comment #2)

How is the profile invalid? Your profile looks very similar to mine.

Huh... When I tried to load it the other day I got some kind of "profile cannot be found" error (don't remember the exact message any more, sorry). But the link works now. Must have been a transient issue.

And yes, I was thinking caching too.

Sounds good, taking.

Assignee: nobody → ehsan
Component: Networking: DNS → Privacy: Anti-Tracking
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55743f55095c
Cache the document's effective storage principal to avoid running excessive anti-tracking checks; r=baku
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

Profile after the change for comparison: https://perfht.ml/2o6wVsV

You need to log in before you can comment on or make changes to this bug.