1588624 - docker-worker should default to having `afterIdleSeconds` set when running in the cloud

Status: RESOLVED FIXED

(Taskcluster :: Workers, defect)

Description

[Tom Prince [:tomprince]]

When started from aws-provisioner, docker-workers have afterIdleSeconds set. I'm not sure where this is getting set. It was set by the aws host type, which was removed by https://github.com/taskcluster/docker-worker/pull/513 and is not used with tc-worker-runner.

I do plan to set this from ci-config, but it would be good if the worker had sensible defaults; particularly as worker-manager doesn't currently terminate instances ever.

Comment 1

[Chris Cooper [:coop] (he/him)]

(In reply to Tom Prince [:tomprince] from comment #0)

I do plan to set this from ci-config, but it would be good if the worker had sensible defaults; particularly as worker-manager doesn't currently terminate instances ever.

Agreed. Since docker-worker-based workers tend to spin up relatively quickly, I'm happy to have the afterIdleSeconds default set pretty low, e.g. 5 minutes. We can increase it like we did in GCP when required.

Comment 2

[Wander Lairson Costa]

docker-worker has a default value set in config.yml

Comment 3

[Tom Prince [:tomprince]]

(In reply to Wander Lairson Costa [:wcosta] from comment #2)

docker-worker has a default value set in config.yml

Experimentally, that was not working the aws-provider images.

Comment 4

[Wander Lairson Costa]

https://github.com/taskcluster/docker-worker/pull/519