1588675 - Use nsPresContext::IsRootContentDocumentCrossProcess instead of IsRootContentDocument for places where we call nsLayoutUtils::ComputeScrollMetadata

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

I am pretty sure this is the right thing to do, but I don't have enough experiences/knowledge to write auto-mated tests for this case.

What I am currently supposing is that FrameMetrics.mIsRootContent is incorrectly set to true in the case of cross-process iframe root scroller, then mZoomAnimationId is set for the iframe's APZC, thus the code which is supposed to be called only for the real root APZC is going to be proccessed, so maybe we can write a test for this particular case.

Anyways, in bug 1586144 I am going to add a function call which has an assertion that checks IsRootContentDocumentCrossProcess in if (aIsRootContent) block in nsLayoutUtils::ComputeScrollMetaData, so I want to fix it prior to the bug.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1da8479263325ff717163e63aad44e5ad0e03fd6

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1588675 - Use nsPresContext::IsRootContentDocumentCrossProcess instead of IsRootContentDocument for places where we call nsLayoutUtils::ComputeScrollMetadata. r?botond

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d6b09a782bb
Use nsPresContext::IsRootContentDocumentCrossProcess instead of IsRootContentDocument for places where we call nsLayoutUtils::ComputeScrollMetadata. r=botond

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2d6b09a782bb