Closed Bug 1588675 Opened Last month Closed Last month

Use nsPresContext::IsRootContentDocumentCrossProcess instead of IsRootContentDocument for places where we call nsLayoutUtils::ComputeScrollMetadata

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I am pretty sure this is the right thing to do, but I don't have enough experiences/knowledge to write auto-mated tests for this case.

What I am currently supposing is that FrameMetrics.mIsRootContent is incorrectly set to true in the case of cross-process iframe root scroller, then mZoomAnimationId is set for the iframe's APZC, thus the code which is supposed to be called only for the real root APZC is going to be proccessed, so maybe we can write a test for this particular case.

Anyways, in bug 1586144 I am going to add a function call which has an assertion that checks IsRootContentDocumentCrossProcess in if (aIsRootContent) block in nsLayoutUtils::ComputeScrollMetaData, so I want to fix it prior to the bug.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1da8479263325ff717163e63aad44e5ad0e03fd6

Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d6b09a782bb
Use nsPresContext::IsRootContentDocumentCrossProcess instead of IsRootContentDocument for places where we call nsLayoutUtils::ComputeScrollMetadata. r=botond
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.