1588747 - [macOS] Title Bar persists in Fullscreen mode

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Camelia Badau [:cbadau], Desktop Test Engineering]

Attachment: issue.png

Affected versions

• Firefox 70 RC
• Firefox Nightly 71.0a1 (2019-10-14)

Affected platforms

• macOS 10.14
• macOS 10.15

Steps to reproduce

1. Launch Firefox.
2. Enable "Title Bar" via "Customize...".
3. Go to Fullscreen (from Hamburger Menu).

Expected result

• Title Bar disappears while in Fullscreen mode.

Actual result

• Title Bar is still visible in Fullscreen mode and overlaps the Tab Bar. Please see attachment "issue.png".

Regression range

• I will come back ASAP with regression range.

Additional notes

• The issue is NOT reproducible on Firefox 69.0.3.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 2

[Markus Stange [:mstange]]

This is terrible. I'm taking a look.

Comment 3

[Markus Stange [:mstange]]

I'm going to look for the regression range now.

I think the bug is not as terrible as I thought it was: This does not happen for new windows that have had titlebars from the start. It only happens if you enable the titlebar on an existing window and then go to fullscreen mode in that window. Any new windows are fine.

Comment 4

[Markus Stange [:mstange]]

On 69, the titlebar also appears under these STR, but it doesn't cover the tabs. It only shows up behind the tabs, in the transparent parts of the fullscreen tab bar. So the "regression" part here is that this unexpected titlebar now covers the tabs.

Comment 5

[Markus Stange [:mstange]]

The first regression (titlebar visible behind tabs) is from bug 1533562. The second regression (titlebar in front of tabs) is from flipping the CoreAnimation pref, bug 1574538.

Comment 6

[Markus Stange [:mstange]]

Attachment: Bug 1588747 - Always insert the TitlebarGradientView underneath its siblings. r=spohl

Usually it covers a different area than the window's ChildView. But in some cases
it can overlap with the ChildView, and in those cases, it's better if the
ChildView is on top.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76e832958b91
Always insert the TitlebarGradientView underneath its siblings. r=spohl

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/76e832958b91

Comment 9

[Ryan VanderMeulen [:RyanVM]]

I'm hesitant to call this wontfix for 70 until we see what happens after we ship. If this proves more common of an issue than comment 3 suggests, we may want to consider this for a dot release ride-along still. Unless we want to take this in the RC2 respin just to be safe?

Comment 10

[Camelia Badau [:cbadau], Desktop Test Engineering]

It seems the issue is fixed on latest Nightly 71.0a1 (2019-10-16) - on macOS 10.15 and macOS 10.14: the Title Bar doesn't cover the tabs anymore while in Full Screen mode.
Also, I can confirm for Firefox 70 what is mentioned in comment 3: this does not happen for new windows that have had Title Bar from the start. The issue is reproducible only in window where you enabled Title Bar (from Customize).

Comment 11

[Markus Stange [:mstange]]

I think this is a good candidate to uplift to release. I don't have a strong opinion on whether it should go into an RC2 respin or as a ride-along into a dot release. I'll request approval so that Liz can make a call.

Comment 12

[Markus Stange [:mstange]]

Comment on attachment 9101373 [details]
Bug 1588747 - Always insert the TitlebarGradientView underneath its siblings. r=spohl

Beta/Release Uplift Approval Request

• User impact if declined: After enabling the title bar from customize mode, putting any of the windows that were open at the time into full screen mode will leave them with a mostly-hidden tab bar (covered by an opaque empty title bar).
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Extremely low-risk one-liner patch.
• String changes made/needed:

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

I'll track for post-release evaluation and possibly including in 70.1.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9101373 [details]
Bug 1588747 - Always insert the TitlebarGradientView underneath its siblings. r=spohl

Simple fix for new regression in 70 in a popular feature, verified in nightly, let's uplift for a 70.1 release as a ridealong.

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/978195f99975

Comment 16

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on macOS 10.14 and macOS 10.15 using Firefox 70.0.1 (buildID: 20191030021342).

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Adding to the 70.0.1 release notes as "Title bar no longer shows in full screen view"