1588861 - XDR encoding modules

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Caroline Cullen [:caroline]]

Currently modules are not being XDRed, and thus do not yet exist in XDR byte cache. Having modules XDRed will allow us to save on module parse time and will eventually allow us to cache standard modules instead of JSM.

Comment 1

[Caroline Cullen [:caroline]]

Attachment: Bug 1588861 - Part 1: Store index into gcThings instead of RootedFunction for FunctionDeclarations inside modules. r=iain

Comment 2

[Caroline Cullen [:caroline]]

Attachment: Bug 1588861 - Part 2: Pull CreateArray out of ModuleBuilder and into js namespace. r=iain

Depends on D53754

Comment 3

[Caroline Cullen [:caroline]]

Attachment: Bug 1588861 - Part 3: Add support for xdr encoding modules into xdr cache. r=iain

Depends on D53755

Comment 4

[Caroline Cullen [:caroline]]

Attachment: Bug 1588861 - Part 4: Add support for round trip module encoding testing. r=iain

Depends on D53756

Comment 5

[Caroline Cullen [:caroline]]

Attachment: Bug 1588861 - Part 3: Add support for xdr encoding modules into xdr cache. r=iain

Depends on D53755

Comment 6

[Caroline Cullen [:caroline]]

Attachment: Bug 1588861 - Part 4: Add test harness for xdr modules. r=iain

Depends on D54158

Comment 7

[Caroline Cullen [:caroline]]

Attachment: Bug 1588861 - Part 5: Tests for xdr modules. r=iain

Depends on D55596

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1eec2b6d898
Part 1: Store index into gcThings instead of RootedFunction for FunctionDeclarations inside modules. r=iain
https://hg.mozilla.org/integration/autoland/rev/639290e9ff22
Part 2: Pull CreateArray out of ModuleBuilder and into js namespace. r=iain
https://hg.mozilla.org/integration/autoland/rev/2a0aacbd11de
Part 3: Add support for xdr encoding modules into xdr cache. r=iain,tcampbell
https://hg.mozilla.org/integration/autoland/rev/b622095c76ab
Part 4: Add test harness for xdr modules. r=iain
https://hg.mozilla.org/integration/autoland/rev/815a452c73af
Part 5: Tests for xdr modules. r=iain

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Assuming this sticks, what else needs to happen for ES modules loaded by the browser in content windows at startup time (eg about:home) to start being cached? Anything?

Comment 10

[Caroline Cullen [:caroline]]

This is the foundation for that, but needs to be hooked into the ScriptLoader.

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c1eec2b6d898
https://hg.mozilla.org/mozilla-central/rev/639290e9ff22
https://hg.mozilla.org/mozilla-central/rev/2a0aacbd11de
https://hg.mozilla.org/mozilla-central/rev/b622095c76ab
https://hg.mozilla.org/mozilla-central/rev/815a452c73af

Comment 12

[Ted Campbell [:tcampbell]]

Moved blocking bugs to Bug 1602931.

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

Thanks for doing this work, Caroline!