1588883 - Fullscreen transition message doesn't appear anymore

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Visit any YouTube video
2. Fullscreen the video

ER:

A message should come down from the top of the screen saying that we've transitioned to fullscreen mode, and that the user needs to press escape to leave it.

AR:

No message.

I expect this is fallout from bug 1505916. Do you have time to look at this, Abdoulaye?

Comment 1

[Mike Conley (:mconley) (:⚙️)]

[Tracking Requested - why for this release]:

The message that tells users how to leave fullscreen is missing, and I imagine we don't want to ship to users without it.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

It might be related to how NewOrigin message is passed. That is the message triggers that notification.

Comment 3

[Abdoulaye O. LY]

(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #2)

It might be related to how NewOrigin message is passed. That is the message triggers that notification.

Thanks Xidorn! I was wondering what this message serves despite trying to disable it to see its effect but was not able to notice that the message disappeared.

(In reply to Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos) from comment #0)

STR:

1. Visit any YouTube video
2. Fullscreen the video

ER:

A message should come down from the top of the screen saying that we've transitioned to fullscreen mode, and that the user needs to press escape to leave it.

AR:

No message.

I expect this is fallout from bug 1505916. Do you have time to look at this, Abdoulaye?

Thanks Mike. I will have a look at this.

Comment 4

[Abdoulaye O. LY]

Attachment: Bug 1588883 - Restore fullscreen transition message. r?mconley

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60de2918cb73
Restore fullscreen transition message. r=mconley

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/60de2918cb73