1589056 - mozlog needs to support PRECONDITION_FAILED test and subtest status

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement, P3)

Description

[Philip Jägenstedt [:foolip]]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.120 Safari/537.36

Steps to reproduce:

https://github.com/web-platform-tests/wpt/pull/16689 needs a PRECONDITION_FAILED status for tests and subtests in order to be able to support the new assert_precondition method in testhharness.js.

Comment 1

[Philip Jägenstedt [:foolip]]

I have prepared some changes in https://github.com/mozilla/gecko-dev/compare/master...foolip:bug1589056?expand=1, requested try access in 1589061 to see if they work at all.

Comment 2

[Philip Jägenstedt [:foolip]]

Attachment: Bug 1589056 - [mozlog] introduce PRECONDITION_FAILED status

This is needed for https://github.com/web-platform-tests/wpt/pull/16689.

Comment 3

[Philip Jägenstedt [:foolip]]

Attachment: Bug 1589056 - [mozlog] introduce PRECONDITION_FAILED status

Comment 4

[Philip Jägenstedt [:foolip]]

Attachment: Bug 1589056 - [mozlog] tests for PRECONDITION_FAILED status

Depends on D50175

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4253a2fb8848
[mozlog] introduce PRECONDITION_FAILED status r=jgraham
https://hg.mozilla.org/integration/autoland/rev/6bd10819c814
[mozlog] tests for PRECONDITION_FAILED status r=jgraham

Comment 6

[Razvan Maries]

Backed out for lint failure on test_formatters.py.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=6bd10819c81400587de52b21fb062ef713ad1835&searchStr=f8

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272562949&repo=autoland&lineNumber=51

Backout: https://hg.mozilla.org/integration/autoland/rev/e72fde5e9c8b77a7815400fc529eb38d8c8fc1e1

Comment 7

[Philip Jägenstedt [:foolip]]

Attachment: Bug 1589056 - [mozlog] introduce PRECONDITION_FAILED status

Resubmitting changes backed out due to lint failure:
https://bugzilla.mozilla.org/show_bug.cgi?id=1589056#c6

Lint and tests verified to work locally with:

./mach lint testing/mozbase/mozlog/
./mach python-test testing/mozbase/mozlog/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/165dd3fa6c49
[mozlog] introduce PRECONDITION_FAILED status r=jgraham
https://hg.mozilla.org/integration/autoland/rev/c8663c3c21a3
[mozlog] tests for PRECONDITION_FAILED status r=jgraham

Comment 9

[Philip Jägenstedt [:foolip]]

Attachment: Bug 1589056 - [mozlog] Update mozlog version number to 5.0 r=jgraham

This is needed to release a new mozlog with the PRECONDITION_FAILED
test and subtest status for use in web-platform-tests.

Update all in-tree dependencies on mozlog to >=5.0. These were found
with hg grep 'mozlog.*[0-9]'.

Only testing/web-platform/tests/tools/wptrunner/requirements.txt
remains on 4.2.0, and it will be updated in upstream wpt after mozlog
5.0 has been released.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/753beb12fdf6
[mozlog] Update mozlog version number to 5.0 r=jgraham

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/165dd3fa6c49
https://hg.mozilla.org/mozilla-central/rev/c8663c3c21a3

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/753beb12fdf6

Comment 13

[Philip Jägenstedt [:foolip]]

Attachment: Bug 1589056 - [mozprofile][mozrunner][mozrunner] bump minor versions r=jgraham

This is needed because the currently released versions use dependencies
like 'mozlog ~= 4.2.0', which won't match the newly released mozlog 5.0.
The dependencies were updated to 'mozlog >= 5.0' recently:
https://hg.mozilla.org/mozilla-central/rev/753beb12fdf6984c0a2ca8786fb9db1317e171b4

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e89821525db
[mozprofile][mozrunner][mozrunner] bump minor versions r=jgraham

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6e89821525db