1589062 - [wpt-sync] Sync PR 19727 - [css-grid] Fix line name positions after implicit tracks

Status: RESOLVED FIXED

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19727 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19727
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

[css-grid] Fix line name positions after implicit tracks

When serializing grid-template-rows/columns of a grid container, we get
the list of used track sizes, and then insert line names at the
corresponding indices.

Before this patch, these indices were simply taken from the computed
value. However, leading implicit tracks appear in the used value but not
in the computed one. Therefore, we have to offset the indices so that
the line names appear at the proper positions.

BUG=790988

TEST=external/wpt/css/css-grid/parsing/grid-template-columns-computed-implicit-track.html
TEST=external/wpt/css/css-grid/parsing/grid-template-rows-computed-implicit-track.html

Change-Id: I778c73034c7ff9fc11a7d8a46a4042cfd1bcd1ae

Reviewed-on: https://chromium-review.googlesource.com/1863092
WPT-Export-Revision: 7ff20baafcf2897555db5277f68d67fd68bc8ac1

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b232a555d290919d23671a76dbf6de888655de2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 24 subtests

Status Summary

Firefox

OK : 2
PASS: 48

Chrome

OK : 2
PASS: 10
FAIL: 38

Safari

OK : 2
PASS: 10
FAIL: 38

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc3ba682d062
[wpt PR 19727] - [css-grid] Fix line name positions after implicit tracks, a=testonly
https://hg.mozilla.org/integration/autoland/rev/07cbc4baafba
[wpt PR 19727] - Update wpt metadata, a=testonly

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/dc3ba682d062
https://hg.mozilla.org/mozilla-central/rev/07cbc4baafba