1589132 - Using debugger yarn setup installed "husky" pre-commit hook

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

For some reason, some hooks were installed in .git/hooks/pre-commit.
It was refering to some node module from debugger folder, so I assumed that it was automatically registered when I did some yarn command from the debugger folder.

I'm not sure this is an expected behavior?
Executing some node modules on everyone's machine should be reviewed carefully. I don't remember any mention of such commit hook.

Comment 1

[Jason Laster [:jlast]]

we can safely remove this dependency. I believe the pre-commit hooks should be removed from the package.json.

diff --git a/devtools/client/debugger/package.json b/devtools/client/debugger/package.json
index d24accb993ce..04e2f165892a 100644
--- a/devtools/client/debugger/package.json
+++ b/devtools/client/debugger/package.json
@@ -132,7 +132,6 @@
     "expect.js": "^0.3.1",
     "flow-bin": "0.97.0",
     "glob": "^7.0.3",
-    "husky": "^1.0.1",
     "jest": "^23.0.0",
     "jest-environment-jsdom": "^23.0.0",
     "jest-in-case": "^1.0.2",

I wonder if they would be removed if you run yarn nom from the debugger directory.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1589132 - Remove husky from debugger.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0e9e96d39ad
Remove husky from debugger. r=jlast

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f0e9e96d39ad