1589182 - Remove mobile/android/extensions/ and /mobile/android/chrome/content

Status: RESOLVED FIXED

(Web Compatibility :: Tooling & Investigations, task, P3)

Description

[Mike Taylor [:miketaylr]]

Fennec no longer lives in m-c, so there's no longer a need for the report-site-issue or webcompat addons to live in mobile/android/extensions/.

For Firefox Preview, the plan is to ship these as Android Components (already done for webcompat, report site issue should happen this quarter).

Comment 1

[Thomas Wisniewski [:twisniewski]]

snorp, we also have some code in mobile/android/chrome/content/browser.js that we could remove here. But why is that directory even still around? Does something still depend on it being in m-c? (I thought it was Fennec-specific)

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Yeah, that whole directory should be removed now.

Comment 3

[Thomas Wisniewski [:twisniewski]]

Just in case: did you mean all of mobile/android/chrome, or just mobile/android/chrome/content?

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Just mobile/android/chrome/content.

Comment 5

[Thomas Wisniewski [:twisniewski]]

Thanks!

... and what about mobile/android/chrome/jar.mn ? Is it safe to leave that alone for now, or should I at least remove the references to content/ inside of it at the same time?

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Thomas Wisniewski [:twisniewski] from comment #5)

Thanks!

... and what about mobile/android/chrome/jar.mn ? Is it safe to leave that alone for now, or should I at least remove the references to content/ inside of it at the same time?

Looks like all of that can go.

Comment 7

[Thomas Wisniewski [:twisniewski]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d170d4b9f0a276cdbafbce076911355a30ac9ec

Comment 8

[Thomas Wisniewski [:twisniewski]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=474435f23398f58a58807ea4068ca628c7ca9bc6

Comment 9

[Thomas Wisniewski [:twisniewski]]

I'm not seeing anything truly worrying in that try-run, so I'll go ahead and submit the patch for review.

Comment 10

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1589182 - remove mobile/android/extensions/ and /mobile/android/chrome/content (Fennec leftovers); r?snorp

Remove mobile/android/extensions/ and /mobile/android/chrome/content from mozilla-central (Fennec leftovers)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa1fe1088a5e
remove mobile/android/extensions/ and /mobile/android/chrome/content (Fennec leftovers); r=snorp,agi

Comment 12

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/fa1fe1088a5e