1589214 - [reviewbot] Long running `node(newtab)` tests are running when they shouldn't

Status: RESOLVED DUPLICATE of bug 1597457

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Greg Mierzwinski [:sparky]]

At the moment, the reviewbot seems to be scheduling node(newtab) tests when it shouldn't (given that it should be restricted to running tests when files change under "browser/components/newtab/**" (see here).

This issue can be seen in this push: https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=da8da0d32cc868eee9f821679896da6a04ef5c0b&selectedJob=271569636

None of the files modified in either of those two patches changed something in the browser/ directory. This test is quite long as well (taking about 2 hours) because of the linux builds it needs.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Are you sure ?
Treeherder says:
Duration: 6 minutes

Comment 2

[Marco Castelluccio [:marco]]

I think the issue is that the node tests depend on the build, so we are basically forced to run the build (which takes 60 minutes) when we run those tests.

Comment 3

[Greg Mierzwinski [:sparky]]

Sorry, I might not have been specific enough. As marco mentions, it's because of the node test's dependency on the build. Also, if you look at the requested and ended times, it shows nearly a 2 hour difference for the node(newtab) test.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:Sylvestre, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Marco Castelluccio [:marco]]

The node debugger tests are not getting scheduled anymore when unneeded, but their dependencies still are :(

I filed bug 1597457 for that.