1589280 - [wpt-sync] Sync PR 19746 - Pass outside fetch client settings object for ServiceWorkerContainer#register()

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19746 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19746
Details from upstream follow.

Kenichi Ishibashi <[e-mail]> wrote:

Pass outside fetch client settings object for ServiceWorkerContainer#register()

A brief summary of this plumbing is below:

blink::ServiceWorkerContainer::registerServiceWorker()
-> (IPC from a renderer to the browser)
-> content::ServiceworkerContextCore::RegisterServiceWorker()
Start a registration job asynchronously
Create a ServiceWorkerVersion and set the passed settings object
-> content::ServiceWorkerVersion::StartWorker()
-> (IPC from the browser to a renderer)
-> WebEmbeddedWorkerImpl::StartWorkerContext()
-> ServiceWorkerGlobalScope::FetchAndRunClassicScript()

Note that renderer processes of above don't have to be the same.

Bug: 937177
Change-Id: I4c137d10b7d5204151ae7eff8bfd8fdeb34fb365
Reviewed-on: https://chromium-review.googlesource.com/1861294
WPT-Export-Revision: 0f3fee8f5f085d001999c006cc2e2ae2651d797d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=196f41b7bd94ad91e68f5513a9f930c6a1758e91

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 1 subtests

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

New tests that's don't pass

/service-workers/service-worker/referer-toplevel-script-fetch.https.html
Referer of the top-level script fetch should be the document URL: Firefox: FAIL, Chrome: FAIL, Safari: PASS

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1589280 [wpt PR 19746] - Pass outside fetch client settings object for ServiceWorkerContainer#register(), a=testonly

Automatic update from web-platform-tests
Pass outside fetch client settings object for ServiceWorkerContainer#register()

A brief summary of this plumbing is below:

blink::ServiceWorkerContainer::registerServiceWorker()
-> (IPC from a renderer to the browser)
-> content::ServiceworkerContextCore::RegisterServiceWorker()
Start a registration job asynchronously
Create a ServiceWorkerVersion and set the passed settings object
-> content::ServiceWorkerVersion::StartWorker()
-> (IPC from the browser to a renderer)
-> WebEmbeddedWorkerImpl::StartWorkerContext()
-> ServiceWorkerGlobalScope::FetchAndRunClassicScript()

(Note that renderer processes of above don't have to be the same.)

This CL has behavioral changes. The 'Referer' header of the request
triggered by register() in a document will be changed.
Before this CL it was the url of the top-level script but after this CL
it is document's url. This behavior is consistent with the spec.

Bug: 937177
Change-Id: I4c137d10b7d5204151ae7eff8bfd8fdeb34fb365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861294
Commit-Queue: Kinuko Yasuda <[e-mail]>
Reviewed-by: Kinuko Yasuda <[e-mail]>
Reviewed-by: Hiroki Nakagawa <[e-mail]>
Reviewed-by: Matt Falkenhagen <[e-mail]>
Cr-Commit-Position: refs/heads/master@{#709462}

--

wpt-commits: 98f4cb23e0c4e16c821721601f1c94c837803ee8
wpt-pr: 19746

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1589280 [wpt PR 19746] - Update wpt metadata, a=testonly

wpt-pr: 19746
wpt-type: metadata

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b76b6ad6e91
[wpt PR 19746] - Pass outside fetch client settings object for ServiceWorkerContainer#register(), a=testonly
https://hg.mozilla.org/integration/autoland/rev/6aad4d54732b
[wpt PR 19746] - Update wpt metadata, a=testonly

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5b76b6ad6e91
https://hg.mozilla.org/mozilla-central/rev/6aad4d54732b