1589446 - Add network id change event (Windows)

Status: RESOLVED FIXED

(Core :: Networking, task, P1)

Description

[Kershaw Chang [:kershaw]]

We need to add a new topic network:network-id-changed to notify that network id is changed.

Comment 1

[Kershaw Chang [:kershaw]]

Nhi, could you find the owner for this bug and also bug 1589447?
I can take the MacOS one.

What do you think about the priority? Maybe P2?

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1589446 - Add network id change event (Windows) r=kershaw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8265027727ef
Add network id change event (Windows) r=kershaw

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for marionette failures on \test_refresh_firefox.py

backout: https://hg.mozilla.org/integration/autoland/rev/1fddd3943a078f176bcba9013c1ffe3022f68e4e

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=mn&tochange=7071b1bdd74110deca5dea19250a2d571223d698&fromchange=8265027727efb5904ceb3efd7c20d07f28119f2b&selectedJob=276118295

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276118295&repo=autoland&lineNumber=49408

[task 2019-11-14T01:31:33.286Z] 01:31:33 INFO - [Child 6840, Chrome_ChildThread] WARNING: pipe error: 1091573695093282 Marionette TRACE Received observer notification xpcom-will-shutdown
[task 2019-11-14T01:31:33.286Z] 01:31:33 INFO - 1573695093282 Marionette DEBUG Remote service is inactive
[task 2019-11-14T01:31:41.712Z] 01:31:41 ERROR - TEST-UNEXPECTED-ERROR | browser\components\migration\tests\marionette\test_refresh_firefox.py TestFirefoxRefresh.testFxANoSync | KeyError: 'keyFetchToken'
[task 2019-11-14T01:31:41.712Z] 01:31:41 INFO - Traceback (most recent call last):
[task 2019-11-14T01:31:41.712Z] 01:31:41 INFO - File "Z:\task_1573693113\build\venv\lib\site-packages\marionette_harness\marionette_test\testcases.py", line 159, in run
[task 2019-11-14T01:31:41.712Z] 01:31:41 INFO - testMethod()
[task 2019-11-14T01:31:41.712Z] 01:31:41 INFO - File "Z:\task_1573693113\build\tests\marionette\tests\browser\components\migration\tests\marionette\test_refresh_firefox.py", line 620, in testFxANoSync
[task 2019-11-14T01:31:41.712Z] 01:31:41 INFO - self.checkFxA()
[task 2019-11-14T01:31:41.712Z] 01:31:41 INFO - File "Z:\task_1573693113\build\tests\marionette\tests\browser\components\migration\tests\marionette\test_refresh_firefox.py", line 421, in checkFxA
[task 2019-11-14T01:31:41.713Z] 01:31:41 INFO - self.assertEqual(result["accountData"]["keyFetchToken"], "top-secret")
[task 2019-11-14T01:31:41.713Z] 01:31:41 INFO - TEST-INFO took 8775ms

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1589446 - Send the network id notification on networkID change (Linux) r=kershaw

Depends on D52689

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1589446 - Send the network id notification on networkID change (Android) r=kershaw

Depends on D53361

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1589446 - Send the network id notification on networkID change (OSX) r=kershaw

Depends on D53362

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f59171e8b83
Add network id change event (Windows) r=kershaw,michal
https://hg.mozilla.org/integration/autoland/rev/0cc1a18d90b9
Send the network id notification on networkID change (Linux) r=kershaw
https://hg.mozilla.org/integration/autoland/rev/b60f50bd25fd
Send the network id notification on networkID change (Android) r=kershaw
https://hg.mozilla.org/integration/autoland/rev/075eabcb0979
Send the network id notification on networkID change (OSX) r=kershaw

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7f59171e8b83
https://hg.mozilla.org/mozilla-central/rev/0cc1a18d90b9
https://hg.mozilla.org/mozilla-central/rev/b60f50bd25fd
https://hg.mozilla.org/mozilla-central/rev/075eabcb0979