1589491 - CalDAV: Switching cache mode does not copy username property

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[John Bieling (:TbSync)]

In
https://searchfox.org/comm-central/source/calendar/base/src/calCalendarManager.js#672

we must add the new "username" property, which was added in bug 1544596.

Comment 1

[John Bieling (:TbSync)]

Attachment: bug1589491_copy_username_when_switching_cache_mode

I totally forgot about this.

Comment 2

[John Bieling (:TbSync)]

Attachment: bug1589491_copy_username_when_switching_cache_mode.patch

Mark it as patch.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3e639553a3b3
Copy username when switching cache mode. r=Fallen

Comment 4

[Magnus Melin [:mkmelin]]

Uplift to 78?

Comment 5

[John Bieling (:TbSync)]

Comment on attachment 9198004 [details] [diff] [review]
bug1589491_copy_username_when_switching_cache_mode.patch

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Username gets lost on switch between online/offline calendar.

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
It seems as it will not cause issues, but a try run will follow.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9198004 [details] [diff] [review]
bug1589491_copy_username_when_switching_cache_mode.patch

[Triage Comment]
Approved for esr78

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.8.1:
https://hg.mozilla.org/releases/comm-esr78/rev/b2f49bc95753