Closed Bug 1589503 Opened 9 months ago Closed 8 months ago

Prevent bad remote triggering data from breaking all messages

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 72
Iteration:
72.1 - Oct 21 - Nov 3
Tracking Status
firefox71 --- wontfix
firefox72 --- fixed

People

(Reporter: Mardak, Assigned: andreio)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The initial stage publishing of an openArticleURL trigger message had hosts placed in patterns instead of params resulting in:

JavaScript error: resource://activity-stream/lib/ASRouterTriggerListeners.jsm, line 99: NS_ERROR_ILLEGAL_VALUE

This specific error is trying to use a "example.com" domain as a MatchPattern, which expects a different format.

This happens when trying to initialize trigger listeners. I suppose we could try/catch around the init and just let this trigger fail ??

Assignee: nobody → andrei.br92
Iteration: --- → 72.1 - Oct 21 - Nov 3
Priority: -- → P1
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f414b9e6d857
Prevent bad remote triggering data from breaking all messages r=Mardak
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in before you can comment on or make changes to this bug.