Closed Bug 1589509 Opened 5 years ago Closed 5 years ago

Add 'Don't show me messages like this again' to feature promotion notifications

Categories

(Firefox :: Protections UI, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 72
Tracking Status
firefox71 --- wontfix
firefox72 --- fixed

People

(Reporter: epang, Assigned: xeonchen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Now that we have more than one notification in for 71 (social and fingerprinters) we should add the "Don't show me messages like this again" checkbox.

Previously we left it out since social tracking was the only doorhanger that would be seen by users.

See spec here:
https://mozilla.invisionapp.com/share/W6T7F6RMJ39#/373229713_Feature_Promotion

Whiteboard: [privacy-panel][triage][skyline]

Gary, would you have time to look into this when you're back? Can this be handled via CFR in some way?

Assignee: xeonchen → nobody
Type: task → enhancement
Flags: needinfo?(xeonchen)
Priority: -- → P3
Assignee: nobody → xeonchen
Status: NEW → ASSIGNED
Flags: needinfo?(xeonchen)

(In reply to Johann Hofmann [:johannh] from comment #1)

Gary, would you have time to look into this when you're back? Can this be handled via CFR in some way?

This feature is very specific, and I don't currently have a good idea how to implement this in CFR.

After discussion with :andreio, we came out some idea about this feature.

Can we place this checkbox in the preferences settings like about:preferences#general-cfrfeatures?

  • This makes more consistent behavior among doorhangers
  • It gives user an opportunity to undo the change
Flags: needinfo?(epang)

(In reply to Gary Chen [:xeonchen] from comment #3)

After discussion with :andreio, we came out some idea about this feature.

Can we place this checkbox in the preferences settings like about:preferences#general-cfrfeatures?

  • This makes more consistent behavior among doorhangers
  • It gives user an opportunity to undo the change

After offline discussion with Eric, we've decided to use an extra button for disabling all doorhangers.

Flags: needinfo?(epang)
Pushed by xeonchen@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/45856f355629
add option to disable all feature promotions; r=fluent-reviewers,flod,andreio
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Waiting for remote-settings approval.

Status: RESOLVED → REOPENED
Flags: needinfo?(xeonchen)
Resolution: FIXED → ---

The settings is ready now.

Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Flags: needinfo?(xeonchen)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: