1589518 - [10.15] Issues trying to switch or drag tabs

Status: RESOLVED FIXED

(External Software Affecting Firefox :: Other, defect, P2)

Description

[Marcia Knous [:marcia]]

Seen while running macOS 10.15.1 ( (19B77a). Firefox 70, build 20191016161957. Also reproduced on Firefox 71, latest nightly build. Not sure where to bucket this.

Seems to have started after I updated to 10.15.1, latest seed.

STR:

1. Have several tabs open (crash-stats.mozilla.com), https://crash-stats.mozilla.com/report/index/7ada37fb-e4b2-4f5b-a481-c895d0191017 is one example
2. Try to switch between them by using the mouse.
3. Try to drag them

Expected: They should move if they are dragged or you should be able to switch tabs with a mouse click

Actual: Nothing happens when I try to do this

Browser console errors:

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMWindowUtils.removeSheetUsingURIString]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone :: line 75" data: no] ExtensionCommon.jsm:75:12

[Exception... "Favicon at "https://hg.mozilla.org/favicon.ico" failed to load: Not Found." nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource:///modules/FaviconLoader.jsm :: onStopRequest :: line 236" data: no] FaviconLoader.jsm:236:22

[Exception... "Favicon at "https://dbaron.org/favicon.ico" failed to load: Not Found." nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource:///modules/FaviconLoader.jsm :: onStopRequest :: line 236" data: no] FaviconLoader.jsm:236:22

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMWindowUtils.removeSheetUsingURIString]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone :: line 75" data: no] 3 ExtensionCommon.jsm:75:12

Comment 1

[Stephen A Pohl [:spohl]]

Does mozregression yield any helpful info?

Comment 2

[Marcia Knous [:marcia]]

I cannot get mozregression to work on my machine. I suspect this is more of an issue of something on the Apple side since I had just updated to 10.15.1, and I will check my other 10.15 machine to see if I can repro it.

Comment 3

[Marcia Knous [:marcia]]

Camelia - When your team moves to the 10.15.1 seed (19B77a), can you please test on your machine to see if you have the same behavior? Thanks.

Comment 4

[Camelia Badau [:cbadau], Desktop Test Engineering]

Attachment: issue.mov

I reproduced the issue on macOS 10.15.1 using Firefox 70 RC2, latest Nightly 72.0a1 and Firefox 71 Beta 3.

I saw the following scenario: if I click on the top of the tab name or even on the tab name, nothing happens; if I click on the bottom of the tab name, everything works properly and I can switch to that tab. The same thing happens when I want to drag a tab.
I think this happens because the tab receive focus only when my mouse cursor is on the bottom part of the tab name. When my mouse cursor is on the top part of the tab name or exactly on the tab name, tab isn't receive any focus and so I can't do any action on this tab.
Please see attachment "issue.mov" (I do not know if the issue is highlighted very well in this attachment).

Comment 5

[Markus Stange [:mstange]]

This may have broken because we're now relying on the private API -[NSView _opaqueRectForWindowMoveWhenInTitlebar]: https://searchfox.org/mozilla-central/rev/8a63fc190b39ed6951abb4aef4a56487a43962bc/widget/cocoa/nsChildView.mm#2642-2660
It's possible they changed how it works.

Comment 6

[Markus Stange [:mstange]]

Hmm, actually, no, that API is just used to stop moving the window. It does not affect whether clicks in the titlebar go to the tab.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Following up on the mozilla-apple discuss list.

Comment 8

[Marcia Knous [:marcia]]

The other thing I noticed is I cannot close a tab using the "x" running the latest Firefox beta. I am running 10.15.1 Beta (19B77a).

Sometimes if I keep switching my mouse around tabs I can get the focus back.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

That may not be the right place. Mike can you help file a bug with apple for this?

Comment 10

[Markus Stange [:mstange]]

I'll file the bug.

Comment 11

[Markus Stange [:mstange]]

I've submitted FB7402960:

Unable to click tabs in Firefox 70 in 10.15.1 19B77a seed (regression from 10.15.0)

AppKit: Incorrect/Unexpected Behavior

10.15.1 (19B77a) appears to include an incompatible change about the way mouse clicks in the title bar of NSWindows with NSWindowStyleMaskFullSizeContentView are treated.
As a result, Firefox 70 is broken: Tabs can no longer be clicked. (The tabs overlap the title bar area of the window.)

Firefox has an NSWindow with the following properties:

• NSWindowStyleMaskFullSizeContentView is included in the style mask
• The titleVisibility property is set to NSWindowTitleHidden
• The titlebarAppearsTransparent property is set to YES

Firefox expects clicks in the titlebar to target subviews of the contentView, for subviews that extend into the titlebar. (In Firefox's case, the view that needs the click events is a ChildView which is a direct subview of the contentView. This view covers the entire window size.)

Firefox links against the 10.11 SDK.

Liz, could you follow up on the list and let them know the feedback ID?

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

We got a response from Apple and they are triaging the bug.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

According to our contact at Apple, this should be fixed in 10.15.1 beta 3 (19B86a).

Comment 16

[Markus Stange [:mstange]]

Marcia, can you please re-test with the new seed? Thanks!

Comment 17

[Marcia Knous [:marcia]]

Tested using the following Firefox versions, running 10.15.1 Beta (19B86a)

70.0
Build ID 20191016161957

71.0b3
Build ID 20191021164841

Version 72.0a1
Build ID 20191024144735

Dev Edition 71.0b3
Build ID 20191021164841

I am not seeing any of the issues with dragging and dropping tabs, closing tabs, or focus issues that I was seeing previously.

Based on this testing, I am resolving this bug fixed.

Comment 18

[Markus Stange [:mstange]]

Thanks!