1589608 - Update Preferences permission lists to support user context and private browsing origin attributes

Status: NEW

(Firefox :: Settings UI, enhancement)

Description

[Paul Zühlcke [:pbz]]

We're isolating permissions by private browsing and user context in Bug 1422056. This is not supported by the permissions lists on the preference page yet. Currently, it only shows one permission per type, per site.

This could be implemented by hiding private browsing permissions, and adding an indicator icon to container permissions.

Comment 1

[Anne (:annevk)]

That still leaves first-party isolation, right? I guess we could show two origins there for now until bug 1572461 is fixed and we ban persistent-storage from third parties. I think at that point all permissions follow the first-party isolation model (unless I'm missing something).

Comment 2

[Paul Zühlcke [:pbz]]

We currently hide private browsing permissions in the sitePermissions.js lists in about:preferences. We could show these session permissions to allow users to revoke them.

Comment 3

[Anne (:annevk)]

So that is for the case where you keep the Private Browsing window open, but are no longer on the site you granted permission to?

It seems somewhat reasonable to show them, but perhaps only if about:preferences is open in an actual Private Browsing window as otherwise users might start thinking the state leaks?

Comment 4

[Paul Zühlcke [:pbz]]

(In reply to Anne (:annevk) from comment #3)

So that is for the case where you keep the Private Browsing window open, but are no longer on the site you granted permission to?

Yes, I think that's the main use-case.

It seems somewhat reasonable to show them, but perhaps only if about:preferences is open in an actual Private Browsing window as otherwise users might start thinking the state leaks?

Showing different entries in about:preferences depending on which window the user is in seems confusing. I think about:preferences is perceived as a global entry point to managing settings.
Instead we could show it for any window, but add an indicator (icon?) so the user can clearly differentiate normal and private browsing permissions.

Comment 5

[Anne (:annevk)]

Well, my point is that it might be confusing to users to see entries in about:preferences showing state of Private Browsing windows in non-Private Browsing windows. UX input would help.