Closed Bug 1589664 Opened 5 years ago Closed 5 years ago

Adapt webrtc tests for fission

Categories

(Core :: WebRTC, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Fission Milestone M4
Tracking Status
firefox72 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 2 obsolete files)

No description provided.

Much of the main patch here is just changing the observer patterns within the tests. It was hard to tell exactly where and when the tests were expecting observers to be fired or not fired. I left in some references to expectNoObserverCalled() for further analysis as I couldn't tell exactly what they were trying to listen to (or not listen to).

Fission Milestone: --- → M4

As it's ongoing task which is related with Fission, I will mark it as P2.

Priority: -- → P2

(In reply to Neil Deakin from comment #4)

It was hard to tell exactly where and when the tests were expecting observers to be fired or not fired. I left in some references to expectNoObserverCalled() for further analysis as I couldn't tell exactly what they were trying to listen to (or not listen to).

The tests are counting how many times the notifications with topics in this list https://searchfox.org/mozilla-central/rev/55aa17110091deef24b913d033ccaf58f9c6d337/browser/base/content/test/webrtc/get_user_media_content_script.js#20-25 are fired, to ensure the expected notifications are fired at the right times, and that there's no unexpected notification, or no unexpectedly duplicated notifications.

Attachment #9102528 - Attachment description: Bug 1589664, add a BrowserTestUtils method to listen to observers in the content process, r=mconley → Bug 1589664, add BrowserTestUtils methods to listen to observers in the content process, r=mconley

Depends on D50279

Attachment #9103645 - Attachment is obsolete: true
Attachment #9103639 - Attachment is obsolete: true
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fbd39e38bd29
add BrowserTestUtils methods to listen to observers in the content process, r=mconley
https://hg.mozilla.org/integration/autoland/rev/1e2e6de168a1
adapt the webrtc tests to work with fission enabled. Remove the webrtc framescript in favour of calling BrowserTestUtils methods or SpecialPowers.spawn instead, r=florian
https://hg.mozilla.org/integration/autoland/rev/fb32c77cd7c7
enable the remaining webrtc tests in fission, r=florian
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: