Adapt webrtc tests for fission
Categories
(Core :: WebRTC, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: enndeakin, Assigned: enndeakin)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 2 obsolete files)
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D49734
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D49736
Assignee | ||
Comment 4•5 years ago
|
||
Much of the main patch here is just changing the observer patterns within the tests. It was hard to tell exactly where and when the tests were expecting observers to be fired or not fired. I left in some references to expectNoObserverCalled() for further analysis as I couldn't tell exactly what they were trying to listen to (or not listen to).
Updated•5 years ago
|
Comment 5•5 years ago
|
||
As it's ongoing task which is related with Fission, I will mark it as P2.
Comment 6•5 years ago
|
||
(In reply to Neil Deakin from comment #4)
It was hard to tell exactly where and when the tests were expecting observers to be fired or not fired. I left in some references to expectNoObserverCalled() for further analysis as I couldn't tell exactly what they were trying to listen to (or not listen to).
The tests are counting how many times the notifications with topics in this list https://searchfox.org/mozilla-central/rev/55aa17110091deef24b913d033ccaf58f9c6d337/browser/base/content/test/webrtc/get_user_media_content_script.js#20-25 are fired, to ensure the expected notifications are fired at the right times, and that there's no unexpected notification, or no unexpectedly duplicated notifications.
Updated•5 years ago
|
Assignee | ||
Comment 7•5 years ago
|
||
Depends on D49734
Assignee | ||
Comment 8•5 years ago
|
||
Depends on D50279
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fbd39e38bd29 add BrowserTestUtils methods to listen to observers in the content process, r=mconley https://hg.mozilla.org/integration/autoland/rev/1e2e6de168a1 adapt the webrtc tests to work with fission enabled. Remove the webrtc framescript in favour of calling BrowserTestUtils methods or SpecialPowers.spawn instead, r=florian https://hg.mozilla.org/integration/autoland/rev/fb32c77cd7c7 enable the remaining webrtc tests in fission, r=florian
Comment 10•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fbd39e38bd29
https://hg.mozilla.org/mozilla-central/rev/1e2e6de168a1
https://hg.mozilla.org/mozilla-central/rev/fb32c77cd7c7
Description
•