1589742 - Collect telemetry on the types of user clicks

Status: RESOLVED FIXED

(Core :: Performance: General, enhancement, P2)

Description

[Sean Feng [:sefeng211]]

To help us improve the responsiveness performance, we'd like to learn what things do user click, and then we can use this data to focus on our responsiveness performance work.

When a click happens, if it requires Firefox to response it, we'd like what kind of click this is. Either a link click, a thing that has js handler bound, or a browser chrome click (maybe we can find more while writing the code).

Comment 1

[Sean Feng [:sefeng211]]

Attachment: data_collection_review_1589742.txt

Comment 2

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9102611 [details]
data_collection_review_1589742.txt

To answer the review, we'll need to know which collection mechanism you plan to use. Either a categorical histogram or a handful of scalars sounds suitable.

"Types of user clicks" isn't very well-defined. It sounds like you're interested in measuring how often a few different kinds of interactions happen. Please be clearer about the boundaries of what you plan to collect. It might make more sense to describe them as separate collections. (Are they all necessarily mouse-driven?)

Please request review again when you know the complete set of what you want to collect and how.

Comment 3

[Sean Feng [:sefeng211]]

Attachment: data_collection_review_1589742.txt

Hi Tim,

I updated the review form and tried to describe it thoroughly, please let me know if it still doesn't make sense.

Comment 4

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9104002 [details]
data_collection_review_1589742.txt

> So the categories could be link click, js handler click, browser chrome click, and maybe there are others, and we'll find out during the development.

I would (still) prefer not to review this until you have the complete set in hand. These sound acceptable in principle.

Comment 5

[Sean Feng [:sefeng211]]

Attachment: Bug 1589742 - Collect telemetry on the types of user clicks

Comment 6

[Sean Feng [:sefeng211]]

Attachment: Bug 1589742 - Collect telemetry on the types of user clicks

Comment 7

[Sean Feng [:sefeng211]]

Tim, the patch is up (still being reviewed, but mostly ready). And we ended up just doing the three categories mentioned in the review form. Do you mind review the form again?

Thanks

Comment 8

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

The data collection review form asks for a temporary collection; the histogram definition in the patch says "expires_in_version": "never". Please update one or the other. (I think a temporary collection makes a lot of sense for a new probe until it's proven to be useful. Either is acceptable.)

Comment 9

[Sean Feng [:sefeng211]]

Updated it to expire in 76.

How does it look now Tim?

Comment 10

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9104002 [details]
data_collection_review_1589742.txt

lgtm; thanks!

--

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in Histograms.json and the probe dictionary.

2) Is there a control mechanism that allows the user to turn the data collection on and off? 

Yes, the Firefox telemetry opt-out.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

n/a

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, interaction data.

5) Is the data collection request for default-on or default-off?

Default-on.

6) Does the instrumentation include the addition of **any *new* identifiers**?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

sefeng is responsible for renewing the collection before it expires in 76.

9) Does the data collection use a third-party collection tool?

No.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78cd6dd843ca
Collect telemetry on the types of user clicks r=smaug

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/78cd6dd843ca