Closed Bug 1589784 Opened 5 years ago Closed 6 months ago

Implement Network.loadingFailed

Categories

(Remote Protocol :: CDP, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: impossibus, Unassigned)

References

Details

(Whiteboard: [puppeteer-beta2-mvp])

https://chromedevtools.github.io/devtools-protocol/tot/Network#event-loadingFailed

Example:

{"method":"Network.loadingFailed","params":{"requestId":"1000019154.7022","timestamp":519853.465592,"type":"Fetch","errorText":"net::ERR_INTERNET_DISCONNECTED","canceled":false}

Given the frequency of usage via https://wiki.mozilla.org/Remote/GutenbergCDPUsage#Events this comes at the very ending of the list. So I don't think it is important right now to get implemented.

Priority: P2 → P3

So what's the difference between those different sites, and especially what does the "In Wordpress gutenberg test suite" section mean compared to the events as listed on GutenbergCDPUsage?

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #4)

So what's the difference between those different sites, and especially what does the "In Wordpress gutenberg test suite" section mean compared to the events as listed on GutenbergCDPUsage?

It's the subset of events encountered during a gutenberg run that are also used somehow in Puppeteer. So to support gutenberg's use of Puppeteer, it makes sense to prioritize those events over others. As we investigate how the events are actually used, we might change the priority.

In the case of loadingFailed, it's relatively infrequent because we usually expect resources to load successfully in a test, but it might be used as part of error handling in test suite setup, for example.

Whiteboard: [puppeteer-alp
Whiteboard: [puppeteer-alp → [puppeteer-alpha]
Priority: P3 → P2

This event gets emitted because Puppeteer by default enables the Network domain. But it doesn't look like that the RequestFailed event from Puppeteer is used by Gutenberg. I would suggest we keep it of the track for Gutenberg for now.

No longer blocks: puppeteer-gutenberg
Priority: P2 → P3
Whiteboard: [puppeteer-alpha]
No longer blocks: 1610454

We might be able to use the http-on-failed-opening-request observer notification similar to devtools to detect security check failures:

https://searchfox.org/mozilla-central/rev/46e3b1ce2cc120a188f6940b5c6eab6b24530e4f/devtools/server/actors/network-monitor/network-observer.js#310-324

See also bug 1638259 comment 21 for issues with CSP and loading resouces like style sheets.

Whiteboard: [puppeteer-beta2-mvp]
Component: CDP: Network → CDP
Severity: normal → S3

We are not going to implement this API for CDP but we will eventually have it for WebDriver BiDi.

Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.