1589786 - Case-insensitive search for text written in the Deseret alphabet doesn't work

Status: RESOLVED FIXED

(Core :: Find Backend, defect)

Description

[Alex Henrie]

1. Consider the example text "𐐐𐐯𐑊𐐬 𐐶𐐯𐑉𐑊𐐼!" ("Hello world!" with a capital H)

2. Search this page for "𐐸𐐯𐑊𐐬" (all-lowercase "hello").

Expected results: "𐐸𐐯𐑊𐐬" matches "𐐐𐐯𐑊𐐬".

Actual results: "𐐸𐐯𐑊𐐬" does not match "𐐐𐐯𐑊𐐬".

The same problem occurs when doing a case-insensitive search with Osage or any other script with both uppercase and lowercase forms that cannot be represented in Unicode's basic multilingual plane.

Comment 1

[Alex Henrie]

Attachment: Bug 1589786 - Handle surrogate pairs in nsFind. r=Ehsan

Comment 2

[Alex Henrie]

Requesting checkin of https://phabricator.services.mozilla.com/D49822

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0063a5b2f5b3
Handle surrogate pairs in nsFind. r=Ehsan

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset 0063a5b2f5b3 (bug 1589786) for causing bustages in TestDLLBlocklist.obj and sandboxBroker.i_o

Backout link: https://hg.mozilla.org/integration/autoland/rev/a26f1627d0bcb8adc8143f9aacdb66e780ce307f

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=a26f1627d0bcb8adc8143f9aacdb66e780ce307f&fromchange=0063a5b2f5b3092f9330c4cd9795e6e39f42fa15&searchStr=build&selectedJob=272791026

Failure logs:

• TestDLLBlocklist.obj:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272792270&repo=autoland&lineNumber=7583
• sandboxBroker.i_o:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272797918&repo=autoland&lineNumber=13575

Comment 5

[Alex Henrie]

Ahhh Windows has its own IS_SURROGATE_PAIR macro, so we'll have to call ours NS_IS_SURROGATE_PAIR.

Comment 6

[Alex Henrie]

Requesting checkin of https://phabricator.services.mozilla.com/D49822

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd540d2cdc4d
Handle surrogate pairs in nsFind. r=Ehsan

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/dd540d2cdc4d