1589865 - "Search with ... in a Private Window" appears for the search restriction token

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Dão Gottwald [:dao]]

STR:

1. make sure you don't have the search bar
2. hit accel+K

Actual: "?" is treated like a search string

Expected: "Search with ... in a Private Window" only appears for proper search strings

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

hm, yeah, I missed that.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

also "? something" should search for "something".

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1589865 - Search in a Private Window appears for the search restriction token. r=Standard8

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

[Tracking Requested - why for this release]: Part of the private-search feature, that is likely to be released with Firefox 71

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d371042fea4f
Search in a Private Window appears for the search restriction token. r=Standard8

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d371042fea4f

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 9102911 [details]
Bug 1589865 - Search in a Private Window appears for the search restriction token. r=Standard8

Beta/Release Uplift Approval Request

• User impact if declined: The Search in a Private Window feature is expected to go live in Firefox 71, this is a case that is not properly handled for one of its sub features
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Type "?" check "Search in a Private Window" does not appear in the urlbar results.
  Type "? test" check "Search in a Private Window" will search for "test" (and not "? test").
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): the fix is limited to this feature, it can't regress anything else.
• String changes made/needed:

Comment 8

[Alexandru Trif, Desktop QA [:atrif]]

Hello! Reproduced the issue with Firefox 71.0a1 (20191019214034) on Windows 10x64.
The issue is verified fixed with Firefox 72.0a1 (20191022214314) using STR from comment 7 on Windows 10x64, Ubuntu 18.04 and macOS 10.14.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9102911 [details]
Bug 1589865 - Search in a Private Window appears for the search restriction token. r=Standard8

P1, has tests, verified on nightly by QA, approved for 71 beta 5, thanks!

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0dfa20097d27

Comment 12

[Alexandru Trif, Desktop QA [:atrif]]

Hello! The issue is verified fixed with Firefox 71.0b5 (20191027125310) from comment 11 on Windows 10x64, Ubuntu 18.04 and macOS 10.14.