1589874 - Wrong priority star rating is displayed in Translate View menu

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect)

Description

[Lan Glad [:upwinxp]]

Attachment: Tag stars

Star ratings for priority of tags (for instance, in Firefox) are displayed correctly on the project's page, however the filters menu lowers the ratings for all tags by one star.

Comment 1

[Matjaz Horvat [:mathjazz]]

Location of the Tags code that works OK (1st screenshot):
https://github.com/mozilla/pontoon/blob/master/pontoon/base/templates/widgets/priority.html

Location of the Filters code that needs to be changed (2nd screenshot):
https://github.com/mozilla/pontoon/blob/master/frontend/src/modules/search/components/FiltersPanel.js#L278

Instruction for setting up Tags locally:
https://mozilla-l10n.github.io/documentation/tools/pontoon/adding_new_project.html#tags

Comment 2

[Raj Sandhu (:rsandhu)]

Thanks for assigning me this bug, Matjaz -- it looks like a good first one for me to fix! To help me get started, I'm referring to the advice at the following link, and I'll likely find and use some similar ones too:

https://www.stevejgordon.co.uk/working-on-your-first-github-issue

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

Hi Raj - since we're running short on the Mentored bugs, please note that another applicant will be working on this bug.

Comment 4

[Raj Sandhu (:rsandhu)]

No worries Adrian, I understand and thanks for letting me know and explaining.

Comment 5

[Monika Maheshwari [:MonikaMaheshwari]]

I would like to work on this issue :)

Comment 6

[Matjaz Horvat [:mathjazz]]

:MonikaMaheshwari: please go ahead. We'll keep Raj as Assignee for now, since there can only be one.

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1456

Comment 8

[[DEACTIVATED] Adrian Gaudebert]

adngdb merged PR #1456: "Fix bug 1589874" in a231f9a.