1589931 - Crash in [@ mozilla::AudioCallbackDriver::PanOutputIfNeeded]

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Julian Seward [:jseward]]

This bug is for crash report bp-f521bff5-edfd-4b15-91cb-a0b5b0191018.

This crash appears in two different instances of the OSX build of 20191017215425.
Possibly it dereferences |out->output_name| without checking it is null?

Top 10 frames of crashing thread:

0  @0x7fff68f263f0 
1 XUL mozilla::AudioCallbackDriver::PanOutputIfNeeded dom/media/GraphDriver.cpp:1026
2 XUL mozilla::detail::RunnableFunction<mozilla::AudioCallbackDriver::DeviceChangedCallback xpcom/threads/nsThreadUtils.h:564
3 XUL nsThreadPool::Run xpcom/threads/nsThreadPool.cpp:256
4 XUL non-virtual thunk to nsThreadPool::Run xpcom/threads/nsThreadPool.cpp
5 XUL nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1225
6 XUL NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486
7 XUL mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:333
8 XUL nsThread::ThreadFunc xpcom/threads/nsThread.cpp:458
9 libnss3.dylib _pt_root nsprpub/pr/src/pthreads/ptthread.c:201

Comment 1

[Paul Adenot (:padenot)]

This is best fixed by mandating valid strings here in cubeb.

Comment 2

[Marcia Knous [:marcia]]

A few crashes showing up in the 11/11 nightly - adding 72 as affected.

Comment 3

[Paul Adenot (:padenot)]

Chunmin, do you have time to do this? Should I do it?

Comment 4

[C.M.Chang[:chunmin]]

Yeah, I could do this.

I think the first thing to decide if we allow cubeb_stream_get_current_device to return a device with NULL output_name or input_name. The AudioUnit Rust backend will return a NULL for output_name when failing getting the current device name. The PulseAudio C and Rust backend does the same thing as well. While the Jack backend will always return a null-terminated(\0) string. If cubeb_stream_get_current_device is disallowed to return a NULL string, we should update document and add a test for that.

Comment 5

[C.M.Chang[:chunmin]]

Attachment: GitHub Pull Request

Comment 6

[C.M.Chang[:chunmin]]

Attachment: Bug 1589931 - P1: Only check non-null current output device. r=padenot

Comment 7

[C.M.Chang[:chunmin]]

Attachment: Bug 1589931 - P2: Update cubeb-audiounit-rs to 0920240. r?padenot

Pick commits:
0920240 - Always return null-terminated strings from current_device (#25)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51cd57a31ea7
P1: Only check non-null current output device. r=padenot
https://hg.mozilla.org/integration/autoland/rev/e6727b7a5391
P2: Update cubeb-audiounit-rs to 0920240. r=padenot

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/51cd57a31ea7
https://hg.mozilla.org/mozilla-central/rev/e6727b7a5391