1590021 - AB converstion runs over and over if the original AB is empty

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Jorg K (CEST = GMT+2)]

I see:
console.log: "Creating new abook.sqlite"
console.log: "Creating new history.sqlite"
every time I start my local build.

OK, I had abook.sqlite, .mab and .mab.bak. So I removed .sqlite and .mab.bak hoping for a one-time conversion. But not so. There's also no
"Renaming ${fileName}.mab to ${fileName}.mab.bak"
log.

Comment 1

[Jorg K (CEST = GMT+2)]

Actually, the .mab file was empty before the conversion.

Comment 2

[Geoff Lankow (:darktrojan)]

I could be wrong but this appears to be caused by the empty .mab.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1590021-addrbook-migration-bugs-1.diff

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9102899 [details] [diff] [review]
1590021-addrbook-migration-bugs-1.diff

Review of attachment 9102899 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=mkmelin

::: mailnews/addrbook/test/unit/test_migration4.js
@@ +8,5 @@
> + * This test profile has an empty (no entries, not zero-length) history book.
> + * Migration should not fail as seen in bug 1590021.
> + */
> +
> +const { fixIterator } = ChromeUtils.import(

you're not using this

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1590021-addrbook-migration-bugs-2.diff

That's true, I'm not using it in the file I copied it from either.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f5a320f3ebce
Fix conversion of empty address book and don't overwrite existing backup files. r=mkmelin