Closed Bug 1590064 Opened 1 year ago Closed 1 year ago

"Webdriver:TakeScreenshot" will fail if captured area exceeds upper maximum bound

Categories

(Testing :: Marionette, defect, P3)

Version 3
defect

Tracking

(firefox72 fixed)

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: whimboo, Assigned: thomas510111, Mentored)

Details

(Whiteboard: [lang=js])

User Story

Please read the following documentation in how to get started:
https://firefox-source-docs.mozilla.org/testing/marionette/NewContributors.html

Attachments

(1 file, 3 obsolete files)

Right now Marionette only checks for the horizontal and vertical bounds when creating a screenshot:

https://searchfox.org/mozilla-central/rev/d7537a9cd2974efa45141d974e5fc7c727f1a78f/testing/marionette/capture.js#87-105

But there is also an upper limit for the area too which I recently implemented for the CDP protocol:

https://searchfox.org/mozilla-central/rev/d7537a9cd2974efa45141d974e5fc7c727f1a78f/remote/domains/parent/Page.jsm#90-94

We should add such a check to Marionette.

The priority flag is not set for this bug.
:automatedtester, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dburns)
Flags: needinfo?(dburns)
Priority: -- → P3

Depends on D51680

Attachment #9106285 - Attachment is obsolete: true
Attachment #9106285 - Attachment is obsolete: false
Attachment #9106285 - Attachment is obsolete: true
Attachment #9107224 - Attachment is obsolete: true
Attachment #9107027 - Attachment is obsolete: true
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33fb2c19be36
[marionette] Restrict maximum screenshot area. r=whimboo
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Assignee: nobody → thomas510111
You need to log in before you can comment on or make changes to this bug.