1590076 - Enable dom/tests/browser/browser_persist_cookies.js for Fission

Status: RESOLVED DUPLICATE of bug 1576188

(Core :: DOM: Security, task, P2)

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Gijs, you helped to add the test in bug 1469916. Would you please take a look and help to enable this for Fission? Thank you.

Comment 2

[:Gijs (out for now; he/him)]

This is because the underlying feature (saving documents / nsiwebbrowserpersist) and its frame walking is broken with cross-origin iframes. We can't do anything to fix this test until that's happened.

Comment 3

[:Gijs (out for now; he/him)]

Attachment: Patch to improve test output in case of failure

For reference, I used this to debug the test a bit.

Comment 4

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 5

[Chris Peterson [:cpeterson]]

Hsin-Yi says this is a long-time unowned area and making it Fission-compatible is not trivial work. A Fission engineer familiar with BrowsingContext and DocShell should probably take this bug.

This bug breaks front-end's document saving.

Comment 6

[Neha Kochar [:neha]]

Thanks for taking this up, Andreas.

Comment 7

[Christoph Kerschbaumer [:ckerschb]]

Hey Andreas, I am currently evaluating open bugs within dom:security that are blocking fission. It seems the test browser_persist_cookies.js is not annotated as failing when fission enabled anymore.

Is there anything left to do within this bug or can we close it?

Comment 8

[Andreas Farre [:farre]]

Yeah, sorry about that. Closed it! Thanks for bringing it to my attention.