Closed Bug 1590076 Opened 1 year ago Closed 5 months ago

Enable dom/tests/browser/browser_persist_cookies.js for Fission

Categories

(Core :: DOM: Security, task, P2)

task

Tracking

()

RESOLVED DUPLICATE of bug 1576188
Fission Milestone M4.1

People

(Reporter: hsinyi, Assigned: farre)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [domsecurity-backlog1])

Attachments

(1 file)

No description provided.

Hi Gijs, you helped to add the test in bug 1469916. Would you please take a look and help to enable this for Fission? Thank you.

Flags: needinfo?(gijskruitbosch+bugs)

This is because the underlying feature (saving documents / nsiwebbrowserpersist) and its frame walking is broken with cross-origin iframes. We can't do anything to fix this test until that's happened.

Depends on: 1576188
Flags: needinfo?(gijskruitbosch+bugs)

For reference, I used this to debug the test a bit.

Priority: -- → P3
Whiteboard: [domsecurity-backlog1]
Depends on: 1596315

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → ?
Fission Milestone: ? → M4.1

Hsin-Yi says this is a long-time unowned area and making it Fission-compatible is not trivial work. A Fission engineer familiar with BrowsingContext and DocShell should probably take this bug.

This bug breaks front-end's document saving.

Priority: P3 → P2

Thanks for taking this up, Andreas.

Assignee: nobody → afarre
Status: NEW → ASSIGNED

Hey Andreas, I am currently evaluating open bugs within dom:security that are blocking fission. It seems the test browser_persist_cookies.js is not annotated as failing when fission enabled anymore.

Is there anything left to do within this bug or can we close it?

Flags: needinfo?(afarre)

Yeah, sorry about that. Closed it! Thanks for bringing it to my attention.

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Flags: needinfo?(afarre)
Resolution: --- → DUPLICATE
Duplicate of bug: 1576188
You need to log in before you can comment on or make changes to this bug.