1590083 - Disable multi-value in Webassembly.validate for Cranelift

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P3)

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

In fact there's no runtime switch, it's enabled by default in Nightly builds, without a way to disable it. We just need to check if Cranelift is enabled to adapt validation. (See also bug 1566427.)

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1590083: Disable wasm multi value with Cranelift; r?lth

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1590083: Put the wasm block depth test into its own file; r?lth

On my (pretty powerful) machine, running binary.js takes 7 seconds before this
patch, 2.5 seconds after the patch. The slow test behaves even worse with
Cranelift, taking up to 20 seconds. Splitting this particular test in its own
test file makes it run in parallel and reduce overall time spent on binary.js.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8204dd5d6f50
Disable wasm multi value with Cranelift; r=lth
https://hg.mozilla.org/integration/autoland/rev/250671bb30b3
Put the wasm block depth test into its own file; r=lth

Comment 5

[Andy Wingo [:wingo]]

(In reply to Benjamin Bouvier [:bbouvier] from comment #1)

In fact there's no runtime switch, it's enabled by default in Nightly builds, without a way to disable it. We just need to check if Cranelift is enabled to adapt validation. (See also bug 1566427.)

Just for clarity: it is enabled by default in nightly shell builds, not browser builds.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8204dd5d6f50
https://hg.mozilla.org/mozilla-central/rev/250671bb30b3