Disable multi-value in Webassembly.validate for Cranelift
Categories
(Core :: JavaScript: WebAssembly, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
References
Details
Attachments
(2 files)
|
Assignee | |
Comment 1•5 years ago
|
||
In fact there's no runtime switch, it's enabled by default in Nightly builds, without a way to disable it. We just need to check if Cranelift is enabled to adapt validation. (See also bug 1566427.)
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
On my (pretty powerful) machine, running binary.js takes 7 seconds before this
patch, 2.5 seconds after the patch. The slow test behaves even worse with
Cranelift, taking up to 20 seconds. Splitting this particular test in its own
test file makes it run in parallel and reduce overall time spent on binary.js.
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8204dd5d6f50 Disable wasm multi value with Cranelift; r=lth https://hg.mozilla.org/integration/autoland/rev/250671bb30b3 Put the wasm block depth test into its own file; r=lth
|
||
Comment 5•5 years ago
|
||
(In reply to Benjamin Bouvier [:bbouvier] from comment #1)
In fact there's no runtime switch, it's enabled by default in Nightly builds, without a way to disable it. We just need to check if Cranelift is enabled to adapt validation. (See also bug 1566427.)
Just for clarity: it is enabled by default in nightly shell builds, not browser builds.
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8204dd5d6f50
https://hg.mozilla.org/mozilla-central/rev/250671bb30b3
Description
•