Closed Bug 1590083 Opened 3 months ago Closed 3 months ago

Disable multi-value in Webassembly.validate for Cranelift

Categories

(Core :: Javascript: WebAssembly, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.

In fact there's no runtime switch, it's enabled by default in Nightly builds, without a way to disable it. We just need to check if Cranelift is enabled to adapt validation. (See also bug 1566427.)

On my (pretty powerful) machine, running binary.js takes 7 seconds before this
patch, 2.5 seconds after the patch. The slow test behaves even worse with
Cranelift, taking up to 20 seconds. Splitting this particular test in its own
test file makes it run in parallel and reduce overall time spent on binary.js.

Blocks: 1590101
Summary: Webassembly.validate doesn't respect the multi-value runtime switch → Disable multi-value in Webassembly.validate for Cranelift
Priority: -- → P3
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8204dd5d6f50
Disable wasm multi value with Cranelift; r=lth
https://hg.mozilla.org/integration/autoland/rev/250671bb30b3
Put the wasm block depth test into its own file; r=lth

(In reply to Benjamin Bouvier [:bbouvier] from comment #1)

In fact there's no runtime switch, it's enabled by default in Nightly builds, without a way to disable it. We just need to check if Cranelift is enabled to adapt validation. (See also bug 1566427.)

Just for clarity: it is enabled by default in nightly shell builds, not browser builds.

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.