Closed Bug 1590111 Opened 3 months ago Closed 3 months ago

[Fission] Make dom/tests/mochitest/bugs/test_bug346659.html fission compatible

Categories

(Core :: DOM: Core & HTML, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla72
Fission Milestone M4
Tracking Status
firefox72 --- fixed

People

(Reporter: jdai, Assigned: timhuang)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → tihuang

This patch makes several changes in order to enable it in Fission.

  1. It changes the way how we close windows in test. The testing windows
    were closed by the script of their child window and iframe. It won't
    work in fission if the testing window and its child are in different
    origins. To address this issue, we close the testing windows by the
    major test script when the test of the testing windows finishes.

  2. We modify the way how testing child window and iframe get the test
    number. It used to get the test number through opener/parent. However,
    the property of the opener/parent is inaccessible if it is cross site.
    So, for load tests, we use url parameter to propagate the test number to
    child window. For write tests, we directly write the test number in the
    markup.

  3. We change to use SpecialPowers.spawn() to access testing window since
    they could be cross origin from the test script.

In addition, we add comments for better understanding the test script
itself.

Pushed by tihuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74408a9fce53
Make the test 'test_bug346659.html' compatible with fission. r=bzbarsky
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.