Closed
Bug 1590195
Opened 5 years ago
Closed 5 years ago
Remove actorHasMethod check for getOffsetParent
Categories
(DevTools :: Inspector: Layout, task, P3)
DevTools
Inspector: Layout
Tracking
(firefox72 fixed)
RESOLVED
FIXED
Firefox 72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: gl, Assigned: anujanmurugesu, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(2 files)
We added this backward compatibility check in Firefox 55 in Bug 1345119. We can remove this check here: https://searchfox.org/mozilla-central/source/devtools/client/inspector/boxmodel/box-model.js#196
Hello, I'm a first time contributor and I would like to tackle this bug. Though by removing the line 196 should the if statement be always true in other words just move lines 202-206 outside the condition and remove it? Thanks
|
Reporter | |
Comment 2•5 years ago
|
||
Yes, the if statement will always be true and therefore we can remove it.
|
||
Comment 3•5 years ago
|
||
Hi there. I was wondering if Anujan is still working on this bug, and if not I would like to work on it? Thanks
Hi Jacob, Yes I am still working on this bug. Was about to post my code for review. Sorry about that
|
|
||
Comment 5•5 years ago
|
||
No problem at all.
|
||
Updated•5 years ago
|
Attachment #9109112 -
Attachment description: Remove actorHasMethod check for getOffsetParent → Bug 1590195 - Remove actorHasMethod check for getOffsetParent
|
|
||
Updated•5 years ago
|
Attachment #9109161 -
Attachment description: Bug 1590195 - Remove actorHasMethodCheck → Bug 1590195 - Remove actorHasMethod check for getOffsetParent
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/449f5545954f Remove actorHasMethodCheck r=gl
|
|
Reporter | |
Updated•5 years ago
|
Assignee: nobody → anujanmurugesu
Status: NEW → ASSIGNED
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in
before you can comment on or make changes to this bug.
Description
•