159020 - Clean up nsCocoaBrowserService

Status: RESOLVED WONTFIX

(Camino Graveyard :: General, enhancement)

Description

[Simon Fraser [no longer active]]

nsCocoaBrowserService currently implments every interface under the sun, and
then some. We need to pull out the different API impls into different classes.
Probably the only one that should remain is nsIWindowCreator. I'd suggest new
classes for the APIs with the following breakdown:

nsUserPrompts for nsIPromptService
nsSecurityDialogs for nsIBadCertListener, nsISecurityWarningDialogs, nsINSSDialogs
nsHelperAppLauncher for nsIHelperAppLauncherDialog

Eventually we should be able to remove nsIFactory from it too.

Comment 1

[Brian Ryner (not reading)]

I've already done the security dialogs stuff in bug 158801.  I was waiting until
after 0.4 to check it in.

Comment 2

[Greg K.]

This would technically be an enhancement, wouldn't it?

Comment 3

[Brian Ryner (not reading)]

Attachment: factor out nsIPromptService

This factors out nsIPromptService into a CocoaPromptService class.  I also had
to make AppComponents a .mm file, since it needs to include headers which
include Cocoa objective C headers.

Comment 4

[Mike Pinkerton (not reading bugmail)]

looks good to me, r=pink

Comment 5

[Brian Ryner (not reading)]

checked in.  leaving bug open for more work.

Comment 6

[Simon Fraser [no longer active]]

nsCocoaBrowserService is gone from camino.