Closed Bug 1590225 Opened 5 years ago Closed 5 years ago

[lando-api] remove "sec-approval" from the reviewers list when landing patches via the sec-approval workflow

Categories

(Conduit :: Lando, defect, P2)

Product:
Conduit
Component:
Lando
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mars, Assigned: mars)

References

(Blocks 1 open bug)

Details

(Keywords: conduit-triaged)

As a sec-approval team member, I don't want my name or the sec-approval team's name to show up in the list of reviewers when landing a commit that has gone through the sec-approval process.

Per dveditz, the whole point of sec-approval is to allow the security team to consult on security issues in private. Having the "sec-approval" team show up as a reviewer of a normal-looking commit defeats that privacy.

This has been deployed to dev for testing.

Depends on: 1596651

This works on DEV, waiting to deploy to PROD.

This has been deployed to production.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.