Closed Bug 1590306 Opened 2 years ago Closed 2 years ago

Force LTR on the shortcut key in the welcome box

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox72 verified)

VERIFIED FIXED
Firefox 72
Tracking Status
firefox72 --- verified

People

(Reporter: itiel_yn8, Assigned: itiel_yn8)

Details

(Keywords: rtl)

Attachments

(2 files)

Attached image Screenshot

... to avoid having the Ctrl+/ shortcut appear in reverse (in RTL), like in the attached screenshot.

To fix this, add direction: ltr and change text-align: end to right in:
https://searchfox.org/mozilla-central/rev/55aa17110091deef24b913d033ccaf58f9c6d337/devtools/client/debugger/src/components/WelcomeBox.css#48

and add the following rule:

.shortcutKey:dir(rtl) {
  text-align: left;
}
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Flags: needinfo?(itiel_yn8)
Flags: needinfo?(itiel_yn8)
Keywords: rtl
Flags: needinfo?(itiel_yn8)

@Itiel, thanks for the report and instructions how to fix it!

Can you please attach a patch so, we can properly land this?

I've tested it already (using instructions in comment #1) and it fixes the problem.

Honza

Priority: -- → P3
Flags: needinfo?(itiel_yn8)
Keywords: checkin-needed

Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec46a6ec3d50
Force LTR on the shortcut key in the welcome box r=Honza

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.