1590306 - Force LTR on the shortcut key in the welcome box

Status: VERIFIED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Itiel]

Attachment: Screenshot

... to avoid having the Ctrl+/ shortcut appear in reverse (in RTL), like in the attached screenshot.

Comment 1

[Itiel]

To fix this, add direction: ltr and change text-align: end to right in:
https://searchfox.org/mozilla-central/rev/55aa17110091deef24b913d033ccaf58f9c6d337/devtools/client/debugger/src/components/WelcomeBox.css#48

and add the following rule:

.shortcutKey:dir(rtl) {
  text-align: left;
}

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Itiel, thanks for the report and instructions how to fix it!

Can you please attach a patch so, we can properly land this?

I've tested it already (using instructions in comment #1) and it fixes the problem.

Honza

Comment 3

[Itiel]

Attachment: Bug 1590306 - Force LTR on the shortcut key in the welcome box r?honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec46a6ec3d50
Force LTR on the shortcut key in the welcome box r=Honza

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ec46a6ec3d50