1590336 - The "CFR Recommendations" are no longer displayed on latest Firefox Nightly

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Notes]

• The "TypeError: notificationText.attributes is undefined" error is displayed in the "Browser Console".

[Affected versions]:

• Firefox Nightly 72.0a1 - Build ID: 20191021215155

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have a new Firefox profile.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Open a new tab and click the "YouTube" top site.
3. Repeat step 2 another 4 times and restart the browser.
4. Open a new tab and click the "YouTube" top site.
5. Observe the right part of the "Address Bar"

[Regression Window]:

• Considering the fact that this issue is not reproducible with the previous version of Nightly, using the mozregression tool I have managed to find the following regression window:
  Last good revision: 28171f948a0874143e59c9551712b8fa08e50f55
  First bad revision: 82a89b1ae03ef722acc5088a215cd28297efbebe
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=28171f948a0874143e59c9551712b8fa08e50f55&tochange=82a89b1ae03ef722acc5088a215cd28297efbebe

From the pushlog, it seems that bug 1587809 has caused this issue.

[Expected result]:

• The "CFR Recommendation" button is successfully displayed in the right part of the "Address Bar".

[Actual result]:

• Only the "Page actions", "Save to Pocket" and "Bookmark this page" buttons are displayed.

[Additional Notes]:

• This issue is reproducible with all the "CFR Recommendations".
• The issue is also reproducible if the "CFR Recommendations" are triggered from the "AS Router" page.
• Attached a screen recording of the issue.

@Jamie, could you please take a look over this issue?

Comment 1

[Andrei Oprea [:andreio]]

This needs an update in Remote Settings.

Comment 2

[Andrei Oprea [:andreio]]

String revert in bug 1590490 fixed this. Follow up changes in RS are in staging and will be migrated to production.

Comment 3

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (72.0a1 Build ID - 20191028094851) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "CFR Recommendations" are successfully displayed.