1590343 - [Win][Ubuntu] Netmonitor Blocking - (re) Center [ X ] inside the Remove Pattern button

Status: RESOLVED DUPLICATE of bug 1589961

(DevTools :: Netmonitor, defect)

Description

[Cristian Fogel [:cfogel]]

Attachment: netblocking_RemovePatternX.png

Affected versions

• 71.0a1 (2019-10-21)

Affected platforms

• Windows 10;

Steps to reproduce
devtools.netmonitor.features.requestBlocking set to true

1. Launch Firefox, access any webpage, open Netmonitor - blocking tab;
2. Block any request;
3. (optional) Zoom in over the DevTools section;
4. Hover over the Remove pattern [x] button;

Expected result

• button is properly displayed;

Actual result

• the X is not centered inside the button;

Regression range

• Pushlog URL;
• Possible regressor: Bug 1587780;

Additional notes

• attached screenshot with the issue;

Comment 1

[Cristian Fogel [:cfogel]]

Adding David in the loop as well for this one.

Comment 2

[Cristian Fogel [:cfogel]]

Updating summary, since with Ubuntu the button is not centered either.

Comment 3

[David Walsh :davidwalsh]

Florens: Do you have thoughts on this? It looks centered on my Mac and on my Windows machine. Additionally, I have background position set to center and the dimensions all look good.

Comment 4

[Florens Verschelde :fvsch]

Attachment: netblocking-remove-pattern-button-fedora.png

Hi Cristian, can you check with the very latest Nightly (72.0a1, Build ID 20191022094606)?

I hadn't seen this issue before, but I think it's fixed by my patch for bug 1589961 which landed during the night. Looking at the row spacing in your screenshot, it kinda looks like what we had just before that patch.

Attached: this is what I'm getting on Fedora 28. Alignment looks pretty good.

Technical details: instead of using the existing .devtools-button style which has a lot of styles already (padding etc.) and overriding its styles, the patch in bug 1589961 creates a new style specifically for this close button. The blue square is a ::before pseudo-element and the icon is a centered background, which should be centered on all platforms.

Comment 5

[Cristian Fogel [:cfogel]]

Thanks for the prompt reply!

Issue still persists with 71.0b3.
Indeed, they look good with 72.0a1 - 20191022214314.

Comment 6

[Florens Verschelde :fvsch]

Hi Harald, do you know what the plan for enabling request blocking?

71 is affected and we could uplift the patch in bug 1589961 to beta (that patch landed just after merge day so there's probably no conflict).

But if we only plan to pref devtools.netmonitor.features.requestBlocking on in 72 or later, uplifting is probably not needed.

Comment 7

[:Harald Kirschner :digitarald]

So far https://bugzilla.mozilla.org/showdependencytree.cgi?id=1583111&hide_resolved=1 only shows P3 issues, which would not block release. Even without green light on release, as it's just a visual fix uplift should be very low risk.

Comment 8

[:Harald Kirschner :digitarald]

Duping as I asked for uplift on the other bug.