1590344 - PYTHONDONTWRITEBYTECODE is unset for no reason anymore

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Anthony Ramine [:nox]]

As explained in a comment in bug 802210, there is no need to unset PYTHONDONTWRITEBYTECODE anymore when using mozbuild, because virtualenv doesn't break in its presence anymore, and has done so for multiple years now.

Comment 1

[Anthony Ramine [:nox]]

Attachment: Bug 1590344 - Don't unset PYTHONDONTWRITEBYTECODE anymore;

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2448f988af9
Don't unset PYTHONDONTWRITEBYTECODE anymore; r=firefox-build-system-reviewers,mshal

Comment 3

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=272632232&resultStatus=testfailed%2Cbusted%2Cexception&revision=e2448f988af9e39a6957d44446b203c24759ea8c&searchStr=python

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272632232&repo=autoland&lineNumber=777

Backout link: https://treeherder.mozilla.org/logviewer.html#?job_id=272632232&repo=autoland

[task 2019-10-23T19:00:04.688Z] 0:51.73 python/mozbuild/mozbuild/test/configure/test_options.py::TestCommandLineHelper::test_precedence PASSED
[task 2019-10-23T19:00:04.688Z] 0:51.73
[task 2019-10-23T19:00:04.689Z] 0:51.73 ========================== 18 passed in 0.73 seconds ===========================
[task 2019-10-23T19:00:11.070Z] 0:58.12 /builds/worker/checkouts/gecko/python/mozbuild/mozbuild/test/configure/lint.py
[task 2019-10-23T19:00:11.071Z] 0:58.12 ============================= test session starts ==============================
[task 2019-10-23T19:00:11.071Z] 0:58.12 platform linux2 -- Python 2.7.12, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/gecko-QUm8IANb-2/bin/python
[task 2019-10-23T19:00:11.071Z] 0:58.12 rootdir: /builds/worker/checkouts/gecko, inifile: /builds/worker/checkouts/gecko/config/mozunit/mozunit/pytest.ini
[task 2019-10-23T19:00:11.071Z] 0:58.12 collecting ... collected 5 items
[task 2019-10-23T19:00:11.072Z] 0:58.12
[task 2019-10-23T19:00:11.072Z] 0:58.12 python/mozbuild/mozbuild/test/configure/lint.py::Lint::test_browser TEST-UNEXPECTED-FAIL
[task 2019-10-23T19:00:11.072Z] 0:58.12 python/mozbuild/mozbuild/test/configure/lint.py::Lint::test_extensions TEST-UNEXPECTED-FAIL
[task 2019-10-23T19:00:11.073Z] 0:58.12 python/mozbuild/mozbuild/test/configure/lint.py::Lint::test_js TEST-UNEXPECTED-FAIL
[task 2019-10-23T19:00:11.073Z] 0:58.12 python/mozbuild/mozbuild/test/configure/lint.py::Lint::test_memory TEST-UNEXPECTED-FAIL
[task 2019-10-23T19:00:11.073Z] 0:58.12 python/mozbuild/mozbuild/test/configure/lint.py::Lint::test_mobile_android TEST-UNEXPECTED-FAIL
[task 2019-10-23T19:00:11.074Z] 0:58.12
[task 2019-10-23T19:00:11.074Z] 0:58.12 =================================== FAILURES ===================================
[task 2019-10-23T19:00:11.074Z] 0:58.12 ______________________________ Lint.test_browser _______________________________
[task 2019-10-23T19:00:11.074Z] 0:58.12
[task 2019-10-23T19:00:11.075Z] 0:58.12 self = <lint.Lint testMethod=test_browser>
[task 2019-10-23T19:00:11.075Z] 0:58.12
[task 2019-10-23T19:00:11.075Z] 0:58.12 def test(self):
[task 2019-10-23T19:00:11.075Z] 0:58.12 > return func(self, project)
[task 2019-10-23T19:00:11.076Z] 0:58.12
[task 2019-10-23T19:00:11.076Z] 0:58.12 python/mozbuild/mozbuild/test/configure/lint.py:25:
[task 2019-10-23T19:00:11.076Z] 0:58.12 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2019-10-23T19:00:11.077Z] 0:58.13 python/mozbuild/mozbuild/test/configure/lint.py:57: in lint
[task 2019-10-23T19:00:11.077Z] 0:58.13 sandbox.run(os.path.join(topsrcdir, 'moz.configure'))
[task 2019-10-23T19:00:11.077Z] 0:58.13 python/mozbuild/mozbuild/configure/lint.py:46: in run
[task 2019-10-23T19:00:11.078Z] 0:58.13 self._check_dependencies(dep)
[task 2019-10-23T19:00:11.078Z] 0:58.13 python/mozbuild/mozbuild/configure/lint.py:144: in _check_dependencies
[task 2019-10-23T19:00:11.078Z] 0:58.13 self._raise_from(e, func)
[task 2019-10-23T19:00:11.078Z] 0:58.13 python/mozbuild/mozbuild/configure/lint.py:112: in _raise_from
[task 2019-10-23T19:00:11.079Z] 0:58.13 thrower(exception)
[task 2019-10-23T19:00:11.079Z] 0:58.13 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2019-10-23T19:00:11.079Z] 0:58.13
[task 2019-10-23T19:00:11.079Z] 0:58.13 e = ConfigureError(u'The dependency on mozbuild_state_path is unused',)
[task 2019-10-23T19:00:11.079Z] 0:58.13
[task 2019-10-23T19:00:11.080Z] 0:58.13 > @depends(target, c_compiler, vc_path, check_build_environment, mozbuild_state_path, when=code_coverage)
[task 2019-10-23T19:00:11.080Z] 0:58.13 @imports('os')
[task 2019-10-23T19:00:11.080Z] 0:58.13 @imports('re')
[task 2019-10-23T19:00:11.080Z] 0:58.13 @imports('mozpack.path')
[task 2019-10-23T19:00:11.080Z] 0:58.13 @imports(_from='builtin', _import='open')
[task 2019-10-23T19:00:11.081Z] 0:58.13 def coverage_flags(target, c_compiler, vc_path, build_env, mozbuild_state_path):
[task 2019-10-23T19:00:11.081Z] 0:58.13 E ConfigureError: The dependency on mozbuild_state_path is unused
[task 2019-10-23T19:00:11.081Z] 0:58.13
[task 2019-10-23T19:00:11.081Z] 0:58.13 build/moz.configure/toolchain.configure:1814: ConfigureError

Comment 4

[Anthony Ramine [:nox]]

:(

I have not a single clue how my patch can lead to that failure, I'll try to reproduce it locally at a later date.

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/886758646be8
Backed out changeset e2448f988af9 for causing python failures on configure/lint.py.

Comment 6

[Anthony Ramine [:nox]]

So given bug 1590714, this was not really my fault, right?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7fd7e3432f4
Don't unset PYTHONDONTWRITEBYTECODE anymore; r=firefox-build-system-reviewers,mshal

Comment 8

[Cosmin Sabou [:CosminS]]

Anthony, yes it was about bug 1590714 as should be fixed by https://hg.mozilla.org/integration/autoland/rev/0a3621d900c8fd0f92f997b87877db90e36cf5f4. Relanded your patch, sorry for the trouble,

Comment 9

[Anthony Ramine [:nox]]

No problem, it's my first time landing a patch so I just wasn't sure what was going on. Thanks for the swift relanding!

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/a7fd7e3432f4