1590399 - permanent failure lines on OS X (Return code: 127) and Windows (Return code: 1)

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Since bug 1565332 landed, at least mochitests, reftests and xpcshell tests have additional lines in the failure summaries, even if the test task didn't fail.

See e.g.
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=272211815&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Csuperseded%2Cretry%2Cusercancel&fromchange=c67e0b10b52fc8e6b17591b77fee324cac2fc38d&tochange=fd0d2f3403803d8a66ceb55595ca5a2202d858e9

For passing tasks, one has to click on 'Failure Summary' at the bottom.

OS X (Return code: 127)
Windows (Return code: 1)

These must be avoided to prevent noise and making classifications more difficult.

Comment 1

[Geoff Brown [:gbrown]]

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272211815&repo=autoland&lineNumber=795

[task 2019-10-21T17:09:11.766Z] 17:09:11     INFO - Running command: pactl load-module module-null-sink
[task 2019-10-21T17:09:11.779Z] 17:09:11     INFO -  /bin/sh: pactl: command not found
[task 2019-10-21T17:09:11.779Z] 17:09:11    ERROR - Return code: 127
[task 2019-10-21T17:09:11.779Z] 17:09:11     INFO - Running command: pactl list modules short
[task 2019-10-21T17:09:11.786Z] 17:09:11     INFO -  /bin/sh: pactl: command not found
[task 2019-10-21T17:09:11.786Z] 17:09:11    ERROR - Return code: 127

Comment 2

[Edwin Takahashi (:egao | infrequent contributor)]

The condition checks should have prevented this, but I probably missed something. Looking at it now.

Comment 3

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1590399 - do not attempt to call pulseaudio initialization (linux only) on other platforms

Comment 4

[Edwin Takahashi (:egao | infrequent contributor)]

The start_pulseaudio method that is called for every desktop_unittest.py call was attempting to run pulseaudio on platforms (macos, windows) that do not have pulseaudio, hence it was causing the exit code.

The fix applies a wrapper around the call to check for env var NEED_PULSEAUDIO.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54b183263967
do not attempt to call pulseaudio initialization (linux only) on other platforms r=gbrown

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/54b183263967