Problems with text manipulation on comment nodes

VERIFIED FIXED in M12

Status

()

Core
DOM: Core & HTML
P3
normal
VERIFIED FIXED
19 years ago
10 years ago

People

(Reporter: dbaron, Assigned: waqar)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

DESCRIPTION:  There are serious problems using the CharacterData interfaces on
comment nodes.  Basically, any call to insertData(), appendData(), or
deleteData() causes the first character in the comment to disappear.

STEPS TO REPRODUCE:
 * load http://www.fas.harvard.edu/~dbaron/dom/test/one-core-html/Comment
 * run tests

ACTUAL RESULTS:  Lots of red.  Each progressive actual result after the first
section has one fewer character at the beginning.

EXPECTED RESULTS:  Green.

DOES NOT WORK CORRECTLY ON:
 * Linux, apprunner, 1999-10-08-08-M11

ADDITIONAL INFORMATION:
In XML, the problem even shows up for the *initial value* of Comment::data.  See
http://www.fas.harvard.edu/~dbaron/dom/test/one-core-xml/Comment

Updated

19 years ago
Assignee: vidur → waqar

Comment 1

19 years ago
Assigning to Waqar for initial investigation.
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

19 years ago
A fixed checked in. The problem now is Kipps code changes for
nsGenericDOMDataNode::AppendData method. With my changes and the old code it
works fine. Then change I made was to nsCommentNode.cpp.
(Assignee)

Updated

19 years ago
Target Milestone: M12
(Assignee)

Updated

19 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

19 years ago
Fix checked in.
Status: RESOLVED → REOPENED
Reopening this one based on Linux mozilla 1999-11-13-08-M12. There's still
something wrong with appendData. That's why two lines in the test page are still
red.
Resolution: FIXED → ---
Reopening this one based on Linux mozilla 1999-11-13-08-M12. There's still
something wrong with appendData. That's why two lines in the test page are still
red.
There is also a problem visible in (the second button of)
http://www.fas.harvard.edu/~dbaron/dom/test/one-core-html/Document .  Could this
have something to do with one-byte versus two-byte characters?
(Assignee)

Updated

19 years ago
Status: REOPENED → RESOLVED
Last Resolved: 19 years ago19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

19 years ago
Fix checked in.

Comment 9

18 years ago
Mass update of qa contact
QA Contact: gerardok → janc
Component: DOM Level 1 → DOM HTML

Comment 10

18 years ago
QA contact Update
QA Contact: janc → desale

Comment 11

17 years ago
Updating QA contact to Shivakiran Tummala.
QA Contact: desale → stummala

Comment 12

17 years ago
verified...i do not see any red lines in the testcases
Status: RESOLVED → VERIFIED

Updated

10 years ago
Component: DOM: HTML → DOM: Core & HTML
QA Contact: stummala → general
You need to log in before you can comment on or make changes to this bug.