1590435 - Preventing default for click events on GeckoView browsers prevents <select> options from opening

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Arturo Mejia [:amejia]]

See fenix issue https://github.com/mozilla-mobile/fenix/issues/6169

Comment 1

[Chris Peterson [:cpeterson]]

Arturo says he can reproduce in both Fenix and GVE.

Temporarily assigning to Dylan because he offered to test.

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Adding this to the November sprint after talking with Emily.

Comment 3

[Dylan Roeh (:droeh) (he/him)]

smaug, can you offer some insight here -- from MDN[0] it sounds to me like this is actually working as intended in GV, and desktop is broken. In particular, the behavior of the checkbox in the MDN example is the same on both desktop and GV (it prevents a user from interacting with the checkbox) and is in line with what GV is doing with the select example Arturo provided. Am I misunderstanding the intended behavior here? (And if so, why wouldn't this prevent the default action when clicking on the select?)

Comment 4

[Chris Peterson [:cpeterson]]

P1 because Dylan says he is working on this bug.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Did you forget to add some link? And I don't quite understand the question. Comment 3 talks about checkbox, but this bug is about <select>.
Checkbox has its own very weird behavior, because of legacy (search for "The legacy-pre-activation behavior for input elements are these steps:" in html spec https://html.spec.whatwg.org/).
And whether or not <select> reacts to click is defined in HTML too - there is no activation behavior, so it doesn't deal with click.

Calling preventDefault() on mousedown is supposed to prevent select to open, or at least browsers do that, though it doesn't seem to be in the spec. And mousedown makes sense here, since that is when the popup opens, not after mouseup.

Comment 6

[Dylan Roeh (:droeh) (he/him)]

Ah, yes, I meant to add https://developer.mozilla.org/en-US/docs/Web/API/Event/preventDefault and forgot, for the checkbox example. But you clarified things for me anyways with the comment about the popup opening on mousedown -- thanks!

Comment 7

[Dylan Roeh (:droeh) (he/him)]

Attachment: Bug 1590435 - Remove defaultPrevented check in GeckoViewPrompt's click handler. r=#geckoview-reviewers!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc73a80c1fef
Remove defaultPrevented check in GeckoViewPrompt's click handler. r=geckoview-reviewers,snorp

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/dc73a80c1fef

Comment 10

[Chris Peterson [:cpeterson]]

firefox71=wontfix because I assume there is no urgent need to uplift this <select> fix to GV Beta (71).